[PATCH]rt73usb: fix for master mode.

[PATCH]rt73usb: fix for master mode.

[Alexandre Becholey]

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

Report status unknown as if there were successfully transmitted.
This will avoid hostapd to disassociate because it doesn't understand what a status unknown is.

Signed-off-by: Alexandre Becholey <alexandre.becholey@epfl.ch>
---
 drivers/net/wireless/rt2x00/rt2x00dev.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-rt73usb-fix-for-master-mode.patch --]
[-- Type: text/x-patch; name="0001-rt73usb-fix-for-master-mode.patch", Size: 745 bytes --]

diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
index f227084..0bbee06 100644
--- a/drivers/net/wireless/rt2x00/rt2x00dev.c
+++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
@@ -280,6 +280,9 @@ void rt2x00lib_txdone(struct queue_entry *entry,
 	if (!(tx_info->flags & IEEE80211_TX_CTL_NO_ACK)) {
 		if (test_bit(TXDONE_SUCCESS, &txdesc->flags))
 			tx_info->flags |= IEEE80211_TX_STAT_ACK;
+                /* Report unkown status as if it was success */
+                else if (test_bit(TXDONE_UNKNOWN, &txdesc->flags))
+                        tx_info->flags |= IEEE80211_TX_STAT_ACK;
 		else if (test_bit(TXDONE_FAILURE, &txdesc->flags))
 			rt2x00dev->low_level_stats.dot11ACKFailureCount++;
 	}

Re: [PATCH]rt73usb: fix for master mode.

[John W. Linville]

On Mon, May 18, 2009 at 02:55:36PM +0200, Alexandre Becholey wrote:
> Report status unknown as if there were successfully transmitted.
> This will avoid hostapd to disassociate because it doesn't understand what a status unknown is.
> 
> Signed-off-by: Alexandre Becholey <alexandre.becholey@epfl.ch>
> ---
>  drivers/net/wireless/rt2x00/rt2x00dev.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 

Seems OK, but...

> diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
> index f227084..0bbee06 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00dev.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
> @@ -280,6 +280,9 @@ void rt2x00lib_txdone(struct queue_entry *entry,
>  	if (!(tx_info->flags & IEEE80211_TX_CTL_NO_ACK)) {
>  		if (test_bit(TXDONE_SUCCESS, &txdesc->flags))
>  			tx_info->flags |= IEEE80211_TX_STAT_ACK;
> +                /* Report unkown status as if it was success */
> +                else if (test_bit(TXDONE_UNKNOWN, &txdesc->flags))
> +                        tx_info->flags |= IEEE80211_TX_STAT_ACK;
>  		else if (test_bit(TXDONE_FAILURE, &txdesc->flags))
>  			rt2x00dev->low_level_stats.dot11ACKFailureCount++;
>  	}

Please use tabs...

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: [PATCH]rt73usb: fix for master mode.

[Ivo van Doorn]

On Monday 18 May 2009, Alexandre Becholey wrote:
> Report status unknown as if there were successfully transmitted.
> This will avoid hostapd to disassociate because it doesn't understand what a status unknown is.
> 
> Signed-off-by: Alexandre Becholey <alexandre.becholey@epfl.ch>
> ---
>  drivers/net/wireless/rt2x00/rt2x00dev.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)

Please put your patches inline, and CC me for rt2x00 related patches.

As for the patch it seems like you indented with spaces rather then tabs?
And please put the comment inside the else statement rather then breaking
the if-elseif-elseif list.

Also have you considered the following things:
	RTS frames success/failure reporting?
	tx_success/tx_failure statistics counters (used in link_tuner as well)

Thanks,

Ivo

Re: [PATCH]rt73usb: fix for master mode.

[Alexandre Becholey]

Ivo van Doorn wrote:
> On Monday 18 May 2009, Alexandre Becholey wrote:
>   
>> Report status unknown as if there were successfully transmitted.
>> This will avoid hostapd to disassociate because it doesn't understand what a status unknown is.
>>
>> Signed-off-by: Alexandre Becholey <alexandre.becholey@epfl.ch>
>> ---
>>  drivers/net/wireless/rt2x00/rt2x00dev.c |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>     
>
> Please put your patches inline, and CC me for rt2x00 related patches.
>   
Yep sorry I forgot to CC you :-/
Oups I forgot an --inline in the git-format-patch
> As for the patch it seems like you indented with spaces rather then tabs?
>   
Sorry first time I submitted a patch... I use vim and I use tabs that's 
strange.
I'll restart from the original file.

> And please put the comment inside the else statement rather then breaking
> the if-elseif-elseif list.
>
> Also have you considered the following things:
> 	RTS frames success/failure reporting?
> 	tx_success/tx_failure statistics counters (used in link_tuner as well)
>
> Thanks,
>
> Ivo
>   
Ok I'll do it, but how should I treat the status unknown for the 
statistics? as a success?

Alexandre

Re: [PATCH]rt73usb: fix for master mode.

[Ivo van Doorn]

> > Also have you considered the following things:
> > 	RTS frames success/failure reporting?
> > 	tx_success/tx_failure statistics counters (used in link_tuner as well)
> >
> > Thanks,
> >
> > Ivo
> >   
> Ok I'll do it, but how should I treat the status unknown for the 
> statistics? as a success?

yeah, since it will be reported as success to mac80211 as well,
it only makes sense to handle it in the statistics as such as well.

Ivo