linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ivo van Doorn <ivdoorn@gmail.com>
To: Alexandre Becholey <alexandre.becholey@epfl.ch>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH]rt73usb: fix for master mode.
Date: Mon, 18 May 2009 15:31:37 +0200	[thread overview]
Message-ID: <200905181531.37484.IvDoorn@gmail.com> (raw)
In-Reply-To: <1242651336-12621-1-git-send-email-alexandre.becholey@epfl.ch>

On Monday 18 May 2009, Alexandre Becholey wrote:
> Report status unknown as if there were successfully transmitted.
> This will avoid hostapd to disassociate because it doesn't understand what a status unknown is.
> 
> Signed-off-by: Alexandre Becholey <alexandre.becholey@epfl.ch>
> ---
>  drivers/net/wireless/rt2x00/rt2x00dev.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)

Please put your patches inline, and CC me for rt2x00 related patches.

As for the patch it seems like you indented with spaces rather then tabs?
And please put the comment inside the else statement rather then breaking
the if-elseif-elseif list.

Also have you considered the following things:
	RTS frames success/failure reporting?
	tx_success/tx_failure statistics counters (used in link_tuner as well)

Thanks,

Ivo





  parent reply	other threads:[~2009-05-18 13:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-18 12:55 [PATCH]rt73usb: fix for master mode Alexandre Becholey
2009-05-18 13:17 ` John W. Linville
2009-05-18 13:31 ` Ivo van Doorn [this message]
2009-05-18 14:42   ` Alexandre Becholey
2009-05-18 14:45     ` Ivo van Doorn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905181531.37484.IvDoorn@gmail.com \
    --to=ivdoorn@gmail.com \
    --cc=alexandre.becholey@epfl.ch \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).