linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
	"johannes@sipsolutions.net" <johannes@sipsolutions.net>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"stable@kernel.org" <stable@kernel.org>
Subject: Re: [PATCH 4/4] cfg80211: fix race between core hint and driver's custom apply
Date: Mon, 18 May 2009 13:04:09 -0700	[thread overview]
Message-ID: <20090518200409.GM20637@tesla> (raw)
In-Reply-To: <20090518184718.GJ2814@tuxdriver.com>

On Mon, May 18, 2009 at 11:47:18AM -0700, John W. Linville wrote:
> On Wed, May 13, 2009 at 05:04:42PM -0400, Luis R. Rodriguez wrote:
> > Its possible for cfg80211 to have scheduled the work and for
> > the global workqueue to not have kicked in prior to a cfg80211
> > driver's regulatory hint or wiphy_apply_custom_regulatory().
> >
> > Although this is very unlikely its possible and should fix
> > this race. When this race would happen you are expected to have
> > hit a null pointer dereference panic.
> >
> > Cc: stable@kernel.org
> > Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> 
> (Same questions as for 3/4...)
> 
> What is the effect of this race?  What justifies this for 2.6.30
> and/or stable?  It is getting late in the cycle for 2.6.30...

It fixes an oops when your global workqueue is hammered during load
of ath9k, ath5k, or ar9170. I finally got confirmation from our team
it does fix the oops. Alan Jenkins also reported it fixed his oops.
He was getting an oops by adding the new RFKILL patches by johannes which
does add stuff ontop of the global workqueue.

  Luis
> 
> John
> --
> John W. Linville                Someday the world will need a hero, and you
> linville@tuxdriver.com                  might be all we have.  Be ready.

      reply	other threads:[~2009-05-18 20:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-13 21:04 [PATCH 0/4] cfg80211: two reg fixes Luis R. Rodriguez
2009-05-13 21:04 ` [PATCH 1/4] cfg80211: return immediately if num reg rules > NL80211_MAX_SUPP_REG_RULES Luis R. Rodriguez
2009-05-13 21:04 ` [PATCH 2/4] cfg80211: cleanup return calls on nl80211_set_reg() Luis R. Rodriguez
2009-05-13 21:04 ` [PATCH 3/4] cfg80211: fix in nl80211_set_reg() Luis R. Rodriguez
2009-05-18 18:46   ` John W. Linville
2009-05-18 20:02     ` Luis R. Rodriguez
2009-05-13 21:04 ` [PATCH 4/4] cfg80211: fix race between core hint and driver's custom apply Luis R. Rodriguez
2009-05-13 22:08   ` Johannes Berg
2009-05-13 22:29     ` Luis R. Rodriguez
2009-05-13 22:35       ` Johannes Berg
2009-05-13 22:37         ` Luis R. Rodriguez
2009-05-14 18:05           ` Luis R. Rodriguez
2009-05-18 18:47   ` John W. Linville
2009-05-18 20:04     ` Luis R. Rodriguez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090518200409.GM20637@tesla \
    --to=lrodriguez@atheros.com \
    --cc=Luis.Rodriguez@Atheros.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).