From: Bob Copeland <me@bobcopeland.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Nick Kossifidis <mickflemm@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
jirislaby@gmail.com, lrodriguez@atheros.com,
linux-wireless@vger.kernel.org, ath5k-devel@lists.ath5k.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] ath5k: prevent infinite loop
Date: Tue, 19 May 2009 08:34:22 -0400 [thread overview]
Message-ID: <20090519123422.GE2580@hash.localnet> (raw)
In-Reply-To: <alpine.DEB.2.00.0905190751200.1767@gandalf.stny.rr.com>
On Tue, May 19, 2009 at 07:54:23AM -0400, Steven Rostedt wrote:
> > Do these patches need to go to 2.6.30?
>
> Considering that it locked up my box, I would think that it should. Well,
> at least the change that checks for the infinite loop.
Yeah, I just wasn't sure if you were using that or -next (which should be
fixed, I guess.) I mistakenly thought Nick posted commit ishs but they
were blobs, the actual commit was:
e5f1d7f3c192c8ebeb492427bab84611ed5568eb "ath5k: fix interpolation with
equal power levels" in wireless-testing.
Those loops really want a helper function...
Hmm, not too familiar with this particular code but getting back -32768
in the degenerate case seems wrong so I'd be inclined towards a hybrid
version of the two that also sanity checks the steps (corrupt eeproms
are bad, but one rather likely corruption is a big block of ones or
zeroes).
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2009-05-19 12:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-19 0:28 [PATCH] ath5k: prevent infinite loop Steven Rostedt
2009-05-19 0:34 ` Nick Kossifidis
2009-05-19 0:43 ` Steven Rostedt
2009-05-19 6:32 ` Nick Kossifidis
2009-05-19 6:39 ` [ath5k-devel] " Luis R. Rodriguez
2009-05-19 11:45 ` Steven Rostedt
2009-05-19 16:38 ` Luis R. Rodriguez
2009-05-19 11:42 ` Bob Copeland
2009-05-19 11:54 ` Steven Rostedt
2009-05-19 12:34 ` Bob Copeland [this message]
2009-05-20 3:37 ` [PATCH] ath5k: avoid and warn on potential " Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090519123422.GE2580@hash.localnet \
--to=me@bobcopeland.com \
--cc=akpm@linux-foundation.org \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=mickflemm@gmail.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).