linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ivo van Doorn <ivdoorn@gmail.com>
To: Alexandre Becholey <alexandre.becholey@epfl.ch>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH v2]rt73usb: fix for master mode
Date: Tue, 19 May 2009 18:38:39 +0200	[thread overview]
Message-ID: <200905191838.40202.IvDoorn@gmail.com> (raw)
In-Reply-To: <1242748376-8993-1-git-send-email-alexandre.becholey@epfl.ch>

On Tuesday 19 May 2009, Alexandre Becholey wrote:
> Report status unknown as if there were successfully transmitted.
> This will avoid hostapd to disassociate because it doesn't understand what a status unknown is.
> 
> Signed-off-by: Alexandre Becholey <alexandre.becholey@epfl.ch>

Looks good. Thanks!

Acked-by: Ivo van Doorn <IvDoorn@gmail.com>

> ---
>  drivers/net/wireless/rt2x00/rt2x00dev.c |    9 ++++++---
>  1 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
> index f227084..57813e7 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00dev.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
> @@ -260,7 +260,8 @@ void rt2x00lib_txdone(struct queue_entry *entry,
>  	 * Update TX statistics.
>  	 */
>  	rt2x00dev->link.qual.tx_success +=
> -	    test_bit(TXDONE_SUCCESS, &txdesc->flags);
> +	    test_bit(TXDONE_SUCCESS, &txdesc->flags) ||
> +	    test_bit(TXDONE_UNKNOWN, &txdesc->flags);
>  	rt2x00dev->link.qual.tx_failed +=
>  	    test_bit(TXDONE_FAILURE, &txdesc->flags);
>  
> @@ -278,14 +279,16 @@ void rt2x00lib_txdone(struct queue_entry *entry,
>  	tx_info->status.rates[1].idx = -1; /* terminate */
>  
>  	if (!(tx_info->flags & IEEE80211_TX_CTL_NO_ACK)) {
> -		if (test_bit(TXDONE_SUCCESS, &txdesc->flags))
> +		if (test_bit(TXDONE_SUCCESS, &txdesc->flags) ||
> +				test_bit(TXDONE_UNKNOWN, &txdesc->flags))
>  			tx_info->flags |= IEEE80211_TX_STAT_ACK;
>  		else if (test_bit(TXDONE_FAILURE, &txdesc->flags))
>  			rt2x00dev->low_level_stats.dot11ACKFailureCount++;
>  	}
>  
>  	if (rate_flags & IEEE80211_TX_RC_USE_RTS_CTS) {
> -		if (test_bit(TXDONE_SUCCESS, &txdesc->flags))
> +		if (test_bit(TXDONE_SUCCESS, &txdesc->flags) ||
> +				test_bit(TXDONE_UNKNOWN, &txdesc->flags))
>  			rt2x00dev->low_level_stats.dot11RTSSuccessCount++;
>  		else if (test_bit(TXDONE_FAILURE, &txdesc->flags))
>  			rt2x00dev->low_level_stats.dot11RTSFailureCount++;



      reply	other threads:[~2009-05-19 16:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-19 15:52 [PATCH v2]rt73usb: fix for master mode Alexandre Becholey
2009-05-19 16:38 ` Ivo van Doorn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905191838.40202.IvDoorn@gmail.com \
    --to=ivdoorn@gmail.com \
    --cc=alexandre.becholey@epfl.ch \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).