linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2]rt73usb: fix for master mode
@ 2009-05-19 15:52 Alexandre Becholey
  2009-05-19 16:38 ` Ivo van Doorn
  0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Becholey @ 2009-05-19 15:52 UTC (permalink / raw)
  To: linux-wireless; +Cc: ivdoorn, Alexandre Becholey

Report status unknown as if there were successfully transmitted.
This will avoid hostapd to disassociate because it doesn't understand what a status unknown is.

Signed-off-by: Alexandre Becholey <alexandre.becholey@epfl.ch>
---
 drivers/net/wireless/rt2x00/rt2x00dev.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
index f227084..57813e7 100644
--- a/drivers/net/wireless/rt2x00/rt2x00dev.c
+++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
@@ -260,7 +260,8 @@ void rt2x00lib_txdone(struct queue_entry *entry,
 	 * Update TX statistics.
 	 */
 	rt2x00dev->link.qual.tx_success +=
-	    test_bit(TXDONE_SUCCESS, &txdesc->flags);
+	    test_bit(TXDONE_SUCCESS, &txdesc->flags) ||
+	    test_bit(TXDONE_UNKNOWN, &txdesc->flags);
 	rt2x00dev->link.qual.tx_failed +=
 	    test_bit(TXDONE_FAILURE, &txdesc->flags);
 
@@ -278,14 +279,16 @@ void rt2x00lib_txdone(struct queue_entry *entry,
 	tx_info->status.rates[1].idx = -1; /* terminate */
 
 	if (!(tx_info->flags & IEEE80211_TX_CTL_NO_ACK)) {
-		if (test_bit(TXDONE_SUCCESS, &txdesc->flags))
+		if (test_bit(TXDONE_SUCCESS, &txdesc->flags) ||
+				test_bit(TXDONE_UNKNOWN, &txdesc->flags))
 			tx_info->flags |= IEEE80211_TX_STAT_ACK;
 		else if (test_bit(TXDONE_FAILURE, &txdesc->flags))
 			rt2x00dev->low_level_stats.dot11ACKFailureCount++;
 	}
 
 	if (rate_flags & IEEE80211_TX_RC_USE_RTS_CTS) {
-		if (test_bit(TXDONE_SUCCESS, &txdesc->flags))
+		if (test_bit(TXDONE_SUCCESS, &txdesc->flags) ||
+				test_bit(TXDONE_UNKNOWN, &txdesc->flags))
 			rt2x00dev->low_level_stats.dot11RTSSuccessCount++;
 		else if (test_bit(TXDONE_FAILURE, &txdesc->flags))
 			rt2x00dev->low_level_stats.dot11RTSFailureCount++;
-- 
1.6.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2]rt73usb: fix for master mode
  2009-05-19 15:52 [PATCH v2]rt73usb: fix for master mode Alexandre Becholey
@ 2009-05-19 16:38 ` Ivo van Doorn
  0 siblings, 0 replies; 2+ messages in thread
From: Ivo van Doorn @ 2009-05-19 16:38 UTC (permalink / raw)
  To: Alexandre Becholey; +Cc: linux-wireless, linville

On Tuesday 19 May 2009, Alexandre Becholey wrote:
> Report status unknown as if there were successfully transmitted.
> This will avoid hostapd to disassociate because it doesn't understand what a status unknown is.
> 
> Signed-off-by: Alexandre Becholey <alexandre.becholey@epfl.ch>

Looks good. Thanks!

Acked-by: Ivo van Doorn <IvDoorn@gmail.com>

> ---
>  drivers/net/wireless/rt2x00/rt2x00dev.c |    9 ++++++---
>  1 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
> index f227084..57813e7 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00dev.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
> @@ -260,7 +260,8 @@ void rt2x00lib_txdone(struct queue_entry *entry,
>  	 * Update TX statistics.
>  	 */
>  	rt2x00dev->link.qual.tx_success +=
> -	    test_bit(TXDONE_SUCCESS, &txdesc->flags);
> +	    test_bit(TXDONE_SUCCESS, &txdesc->flags) ||
> +	    test_bit(TXDONE_UNKNOWN, &txdesc->flags);
>  	rt2x00dev->link.qual.tx_failed +=
>  	    test_bit(TXDONE_FAILURE, &txdesc->flags);
>  
> @@ -278,14 +279,16 @@ void rt2x00lib_txdone(struct queue_entry *entry,
>  	tx_info->status.rates[1].idx = -1; /* terminate */
>  
>  	if (!(tx_info->flags & IEEE80211_TX_CTL_NO_ACK)) {
> -		if (test_bit(TXDONE_SUCCESS, &txdesc->flags))
> +		if (test_bit(TXDONE_SUCCESS, &txdesc->flags) ||
> +				test_bit(TXDONE_UNKNOWN, &txdesc->flags))
>  			tx_info->flags |= IEEE80211_TX_STAT_ACK;
>  		else if (test_bit(TXDONE_FAILURE, &txdesc->flags))
>  			rt2x00dev->low_level_stats.dot11ACKFailureCount++;
>  	}
>  
>  	if (rate_flags & IEEE80211_TX_RC_USE_RTS_CTS) {
> -		if (test_bit(TXDONE_SUCCESS, &txdesc->flags))
> +		if (test_bit(TXDONE_SUCCESS, &txdesc->flags) ||
> +				test_bit(TXDONE_UNKNOWN, &txdesc->flags))
>  			rt2x00dev->low_level_stats.dot11RTSSuccessCount++;
>  		else if (test_bit(TXDONE_FAILURE, &txdesc->flags))
>  			rt2x00dev->low_level_stats.dot11RTSFailureCount++;



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-05-19 16:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-19 15:52 [PATCH v2]rt73usb: fix for master mode Alexandre Becholey
2009-05-19 16:38 ` Ivo van Doorn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).