[PATCH v2.6.30 and w-t] iwlwifi: update 5000 ucode support to version 2 of API

[PATCH v2.6.30 and w-t] iwlwifi: update 5000 ucode support to version 2 of API

[Reinette Chatre]

From: Jay Sternberg <jay.e.sternberg@linux.intel.com>

enable iwl driver to support 5000 ucode having version 2 of API

Signed-off-by: Jay Sternberg <jay.e.sternberg@linux.intel.com>
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
---
This ucode indicates an API change. The backward compatibility support
can already be found in 2.6.30 and wireless-testing in commit
964c32bdc88b3d15dce34bb9ed0903e78e95fd57 "iwlwifi: correct API command
overlap"

Announcement of ucode availability to follow shortly.

 drivers/net/wireless/iwlwifi/iwl-5000.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/iwlwifi/iwl-5000.c b/drivers/net/wireless/iwlwifi/iwl-5000.c
index e61b67d..3681315 100644
--- a/drivers/net/wireless/iwlwifi/iwl-5000.c
+++ b/drivers/net/wireless/iwlwifi/iwl-5000.c
@@ -46,7 +46,7 @@
 #include "iwl-6000-hw.h"
 
 /* Highest firmware API version supported */
-#define IWL5000_UCODE_API_MAX 1
+#define IWL5000_UCODE_API_MAX 2
 #define IWL5150_UCODE_API_MAX 2
 
 /* Lowest firmware API version supported */
-- 
1.5.6.3

Re: [PATCH v2.6.30 and w-t] iwlwifi: update 5000 ucode support to version 2 of API

[John W. Linville]

On Tue, May 19, 2009 at 02:56:36PM -0700, Reinette Chatre wrote:
> From: Jay Sternberg <jay.e.sternberg@linux.intel.com>
> 
> enable iwl driver to support 5000 ucode having version 2 of API
> 
> Signed-off-by: Jay Sternberg <jay.e.sternberg@linux.intel.com>
> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
> ---
> This ucode indicates an API change. The backward compatibility support
> can already be found in 2.6.30 and wireless-testing in commit
> 964c32bdc88b3d15dce34bb9ed0903e78e95fd57 "iwlwifi: correct API command
> overlap"
> 
> Announcement of ucode availability to follow shortly.

Does this fix a bug?  What about it merits inclusion for 2.6.30?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: [PATCH v2.6.30 and w-t] iwlwifi: update 5000 ucode support to version 2 of API

[reinette chatre]

Hi John,

On Tue, 2009-05-19 at 15:35 -0700, John W. Linville wrote:
> On Tue, May 19, 2009 at 02:56:36PM -0700, Reinette Chatre wrote:
> > From: Jay Sternberg <jay.e.sternberg@linux.intel.com>
> > 
> > enable iwl driver to support 5000 ucode having version 2 of API
> > 
> > Signed-off-by: Jay Sternberg <jay.e.sternberg@linux.intel.com>
> > Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
> > ---
> > This ucode indicates an API change. The backward compatibility support
> > can already be found in 2.6.30 and wireless-testing in commit
> > 964c32bdc88b3d15dce34bb9ed0903e78e95fd57 "iwlwifi: correct API command
> > overlap"
> > 
> > Announcement of ucode availability to follow shortly.
> 
> Does this fix a bug?  What about it merits inclusion for 2.6.30?


Sorry for not including this information in original submit. The big fix
that people are waiting on is the fix for the "wrong command queue"
problem that shows up irregularly. This is tracked in
http://www.intellinuxwireless.org/bugzilla/show_bug.cgi?id=1946 and
http://www.intellinuxwireless.org/bugzilla/show_bug.cgi?id=1963 (marked
as duplicates). We used to have a bug for this in kernel.org bugzilla
(http://bugzilla.kernel.org/show_bug.cgi?id=12819 ) but it has been
closed as unreproducible.

Another big fix is an issue that the calibration was run in wrong
order ... one calibration needed information from another run, but it
was run before the one it depended on. This resulted in poor
performance. Unfortunately we do not have a bug report for this.

The other fixes in this firmware are "nice to have".

Reinette