From: Ivo van Doorn <ivdoorn@gmail.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com,
Andrew Morton <akpm@linux-foundation.org>,
linville@tuxdriver.com
Subject: Re: [PATCH] wireless: beyond ARRAY_SIZE of intf->crypto_stats
Date: Wed, 20 May 2009 18:36:55 +0200 [thread overview]
Message-ID: <200905201836.56071.IvDoorn@gmail.com> (raw)
In-Reply-To: <4A134B08.3080803@gmail.com>
On Wednesday 20 May 2009, Roel Kluin wrote:
> Do not go beyond ARRAY_SIZE of intf->crypto_stats
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
I really hope the previous code never resulted in a crash,
since then I would have to look into strange values coming
from the hardware. ;)
Thanks.
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
> ---
> diff --git a/drivers/net/wireless/rt2x00/rt2x00debug.c b/drivers/net/wireless/rt2x00/rt2x00debug.c
> index 07d378e..7b3ee8c 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00debug.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00debug.c
> @@ -138,7 +138,7 @@ void rt2x00debug_update_crypto(struct rt2x00_dev *rt2x00dev,
>
> if (cipher == CIPHER_TKIP_NO_MIC)
> cipher = CIPHER_TKIP;
> - if (cipher == CIPHER_NONE || cipher > CIPHER_MAX)
> + if (cipher == CIPHER_NONE || cipher >= CIPHER_MAX)
> return;
>
> /* Remove CIPHER_NONE index */
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2009-05-20 16:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-20 0:12 [PATCH] wireless: beyond ARRAY_SIZE of intf->crypto_stats Roel Kluin
2009-05-20 16:36 ` Ivo van Doorn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905201836.56071.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=roel.kluin@gmail.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).