From: Tobias Doerffel <tobias.doerffel@gmail.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: linville@tuxdriver.com, mickflemm@gmail.com,
lrodriguez@atheros.com, me@bobcopeland.com,
linux-wireless@vger.kernel.org, ath5k-devel@venema.h4ckr.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ath5k: add support for radio LED
Date: Wed, 20 May 2009 22:16:42 +0200 [thread overview]
Message-ID: <200905202216.43996.tobias.doerffel@gmail.com> (raw)
In-Reply-To: <1242850139-25438-1-git-send-email-jirislaby@gmail.com>
[-- Attachment #1: Type: Text/Plain, Size: 776 bytes --]
Hi,
Am Mittwoch, 20. Mai 2009 22:08:57 schrieb Jiri Slaby:
> From: Tobias Doerffel <tobias.doerffel@gmail.com>
>
> I found these patches on the web not being merged since Jan. Was
> there any reason why they shouldn't be accepted?
Yes - they needed further work. The approach was wrong because the GPIO does
not control the LED rather than some internal rfkill mechanism (which itself
controls the LED). I therefore reworked things to have general RFKILL support
in ath5k and proposed the patches. They were reviewed by Bob Copeland and I
addressed most of the issues so far but didn't come up with a new patch yet,
as there're still minor things to be worked out. If there's interest, I'll
prepare a new patch which represents the current state.
Toby
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-05-20 21:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1242850139-25438-1-git-send-email-jirislaby@gmail.com>
2009-05-20 20:08 ` [PATCH 2/3] ath5k: led, cleanup and prepare macros Jiri Slaby
2009-05-20 20:16 ` Tobias Doerffel [this message]
2009-05-20 20:28 ` [PATCH 1/3] ath5k: add support for radio LED Jiri Slaby
2009-05-20 20:29 ` Bob Copeland
2009-05-20 20:33 ` Tobias Doerffel
2009-05-20 20:41 ` [ath5k-devel] " Bob Copeland
2009-05-22 12:35 ` Bob Copeland
2009-05-25 23:24 ` [PATCH] ath5k: added initial RFKILL support Tobias Doerffel
2009-05-25 23:32 ` Johannes Berg
2009-05-29 22:33 ` Tobias Doerffel
2009-05-29 23:14 ` Johannes Berg
2009-05-30 15:26 ` [ath5k-devel] " Alan Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905202216.43996.tobias.doerffel@gmail.com \
--to=tobias.doerffel@gmail.com \
--cc=ath5k-devel@venema.h4ckr.net \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).