From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from out1.smtp.messagingengine.com ([66.111.4.25]:59572 "EHLO out1.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754454AbZE0CzS (ORCPT ); Tue, 26 May 2009 22:55:18 -0400 Date: Tue, 26 May 2009 23:55:16 -0300 From: Henrique de Moraes Holschuh To: "John W. Linville" Cc: Will Keaney , Johannes Berg , linux-wireless Subject: Re: [PATCH v11] rfkill: rewrite Message-ID: <20090527025516.GC22235@khazad-dum.debian.net> References: <1242942720.4212.19.camel@johannes.local> <1243068246.4606.45.camel@johannes.local> <4A1BDE51.7020009@gmail.com> <20090526131533.GA3932@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20090526131533.GA3932@tuxdriver.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 26 May 2009, John W. Linville wrote: > On Tue, May 26, 2009 at 08:19:29AM -0400, Will Keaney wrote: > > Johannes Berg wrote: > > > This patch completely rewrites the rfkill core to address > > > the following deficiencies: > > > > > I applied this to a fresh pull of wireless-testing this morning, and > > haven't had any problems from it. It looks like the soft lockup I > > reported earlier has been fixed. > > Cool, thanks for the report. > > I'm leaning towards merging this in time for the 2.6.31 merge > window...who wants to complain? :-) As long as the missing userspace control functionality (the lack of which is a _serious_ regression for platform drivers) is added before 2.6.31 ships, I have no complains. Userspace must be able to change the (soft) state using sysfs. This is not an optional part of rfkill :-) -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh