From: Tobias Doerffel <tobias.doerffel@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Bob Copeland <me@bobcopeland.com>,
Jiri Slaby <jirislaby@gmail.com>,
ath5k-devel@lists.ath5k.org, mickflemm@gmail.com,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ath5k: added initial RFKILL support
Date: Sat, 30 May 2009 00:33:07 +0200 [thread overview]
Message-ID: <200905300033.12204.tobias.doerffel@gmail.com> (raw)
In-Reply-To: <1243294366.29222.10.camel@johannes.local>
[-- Attachment #1: Type: Text/Plain, Size: 873 bytes --]
Hi,
Am Dienstag, 26. Mai 2009 01:32:46 schrieb Johannes Berg:
> On Tue, 2009-05-26 at 01:24 +0200, Tobias Doerffel wrote:
> > + err = rfkill_register(sc->rf_kill.rfkill);
> > + if (err) {
> > + sc->rf_kill.rfkill = NULL;
> > + return -1;
> > + }
>
> Missing rfkill_free, and why -EPERM?
Thanks for this remark. I fixed the code and will post an updated patch soon.
Any other comments on the patch? If not, any chance to get it merged into
wireless-testing branch?
> Could you try to work against v11
> of my rfkill patch, or better even against the cfg80211 rfkill instead?
I didn't look at both of them yet. However I think we first should try to get
current rfkill support into mainline as fast as possible. Improvements and
adaptations to reworked rfkill framework can follow.
Regards,
Toby
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-05-29 22:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1242850139-25438-1-git-send-email-jirislaby@gmail.com>
2009-05-20 20:08 ` [PATCH 2/3] ath5k: led, cleanup and prepare macros Jiri Slaby
2009-05-20 20:16 ` [PATCH 1/3] ath5k: add support for radio LED Tobias Doerffel
2009-05-20 20:28 ` Jiri Slaby
2009-05-20 20:29 ` Bob Copeland
2009-05-20 20:33 ` Tobias Doerffel
2009-05-20 20:41 ` [ath5k-devel] " Bob Copeland
2009-05-22 12:35 ` Bob Copeland
2009-05-25 23:24 ` [PATCH] ath5k: added initial RFKILL support Tobias Doerffel
2009-05-25 23:32 ` Johannes Berg
2009-05-29 22:33 ` Tobias Doerffel [this message]
2009-05-29 23:14 ` Johannes Berg
2009-05-30 15:26 ` [ath5k-devel] " Alan Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905300033.12204.tobias.doerffel@gmail.com \
--to=tobias.doerffel@gmail.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).