linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: Luis Rodriguez <lrodriguez@atheros.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"parag.warudkar@gmail.com" <parag.warudkar@gmail.com>,
	Gaurav Jauhar <Gaurav.Jauhar@Atheros.com>,
	"fabian.deutsch@gmx.de" <fabian.deutsch@gmx.de>,
	"arxs@fedoraproject.org" <arxs@fedoraproject.org>,
	"linville@tuxdriver.com" <linville@tuxdriver.com>,
	"debaditya@gmail.com" <debaditya@gmail.com>,
	Senthilkumar Balasubramanian
	<Senthilkumar.Balasubramanian@Atheros.com>,
	"drago01@gmail.com" <drago01@gmail.com>,
	"ath9k-devel@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>,
	"michal@harddata.com" <michal@harddata.com>,
	"leann.ogasawara@canonical.com" <leann.ogasawara@canonical.com>,
	"tim.gardner@canonical.com" <tim.gardner@canonical.com>,
	"jirislaby@gmail.com" <jirislaby@gmail.com>
Subject: Re: [ath9k-devel] Pending ath9k bugs
Date: Tue, 2 Jun 2009 10:39:04 +0530	[thread overview]
Message-ID: <20090602050904.GC17632@vasanth-laptop> (raw)
In-Reply-To: <43e72e890906011252s43d2c596m6ec79569f5074837@mail.gmail.com>

 
> BUG_ON in rc.c when using 11n. This could be caused by an incorrect
> assumption in ath9k that the rc priv is correctly for the target rate.
> The issue may be seen when trying to associate and changing between
> legacy and HT rates on SMP systems when mac80211 passes frames on
> different queues due to multiqueue support. If that is indeed the
> reason for the issue we will probably need locking on the rc priv or
> simply to revamp it. I'll send a patch for now to downgrade the BUG_ON
> but we do need a proper fix for this, it just needs more careful
> review.

I agree that rc priv needs proper locking, but I dont think this
particular issue is related to some race in rc priv. As I already
mentioned in one of the mails related to this problem, the root
cause can be a failure in channel set, have we confirmed that?.
I tried to reproduce this on my setup but no luck.

> 
> While on the topic I should mention a welcomed change would be to
> actually revamp ath9k RC to fix it to correctly report MCS rates to
> mac80211. 

This needs complete rewrite of ath9k rate control alg.


Vasanth



      reply	other threads:[~2009-06-02  5:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-01 18:41 Pending ath9k bugs Luis R. Rodriguez
2009-06-01 18:48 ` [ath9k-devel] " Luis R. Rodriguez
2009-06-01 19:30 ` Jiri Slaby
2009-06-01 19:52 ` [ath9k-devel] " Luis R. Rodriguez
2009-06-02  5:09   ` Vasanthakumar Thiagarajan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090602050904.GC17632@vasanth-laptop \
    --to=vasanth@atheros.com \
    --cc=Gaurav.Jauhar@Atheros.com \
    --cc=Senthilkumar.Balasubramanian@Atheros.com \
    --cc=arxs@fedoraproject.org \
    --cc=ath9k-devel@lists.ath9k.org \
    --cc=debaditya@gmail.com \
    --cc=drago01@gmail.com \
    --cc=fabian.deutsch@gmx.de \
    --cc=jirislaby@gmail.com \
    --cc=leann.ogasawara@canonical.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=lrodriguez@atheros.com \
    --cc=michal@harddata.com \
    --cc=parag.warudkar@gmail.com \
    --cc=tim.gardner@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).