From: Michael Buesch <mb@bu3sch.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [RFT 3/3] b43/legacy: port to cfg80211 rfkill
Date: Tue, 2 Jun 2009 22:08:46 +0200 [thread overview]
Message-ID: <200906022208.46288.mb@bu3sch.de> (raw)
In-Reply-To: <1243973079.6461.3.camel@johannes.local>
On Tuesday 02 June 2009 22:04:39 Johannes Berg wrote:
> On Tue, 2009-06-02 at 16:41 +0200, Michael Buesch wrote:
>
> > > --- wireless-testing.orig/drivers/net/wireless/b43/Kconfig 2009-06-02 12:53:36.000000000 +0200
> > > +++ wireless-testing/drivers/net/wireless/b43/Kconfig 2009-06-02 12:56:11.000000000 +0200
> > > @@ -98,13 +98,6 @@ config B43_LEDS
> > > depends on B43 && MAC80211_LEDS && (LEDS_CLASS = y || LEDS_CLASS = B43)
> > > default y
> > >
> > > -# This config option automatically enables b43 RFKILL support,
> > > -# if it's possible.
> > > -config B43_RFKILL
> > > - bool
> > > - depends on B43 && (RFKILL = y || RFKILL = B43)
> > > - default y
> >
> > Don't you need to add a new "depends on" to "B43", if you remove this?
> > Or is rfkill always compiled in if wireless is present?
>
> Well, rfkill isn't always present but the APIs are always present.
Ok, makes sense, so I guess you rewrote the API. ;)
I'll ack this, if somebody with rfkill device tests it.
Unfortunately I don't have such a device.
--
Greetings, Michael.
next prev parent reply other threads:[~2009-06-02 20:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 11:10 [RFT 0/3] driver rfkill to cfg80211 ports Johannes Berg
2009-06-02 11:10 ` [RFT 1/3] iwlwifi: port to cfg80211 rfkill Johannes Berg
2009-06-03 21:12 ` reinette chatre
2009-06-04 9:03 ` Johannes Berg
2009-06-04 16:02 ` reinette chatre
2009-06-02 11:10 ` [RFT 2/3] ath9k: " Johannes Berg
2009-06-10 13:20 ` Vasanthakumar Thiagarajan
2009-06-10 13:32 ` Vasanthakumar Thiagarajan
2009-06-10 14:38 ` Johannes Berg
2009-06-11 6:52 ` Vasanthakumar Thiagarajan
2009-06-11 9:57 ` Johannes Berg
2009-06-11 9:59 ` Vasanthakumar Thiagarajan
2009-06-11 10:10 ` Johannes Berg
2009-06-11 10:39 ` Vasanthakumar Thiagarajan
2009-06-11 10:40 ` Vasanthakumar Thiagarajan
2009-06-02 11:10 ` [RFT 3/3] b43/legacy: " Johannes Berg
2009-06-02 14:41 ` Michael Buesch
2009-06-02 20:04 ` Johannes Berg
2009-06-02 20:08 ` Michael Buesch [this message]
2009-06-02 20:11 ` Johannes Berg
2009-06-02 20:59 ` Larry Finger
2009-06-02 21:01 ` Johannes Berg
2009-06-02 23:26 ` Larry Finger
2009-06-03 7:52 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906022208.46288.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Larry.Finger@lwfinger.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).