From: "John W. Linville" <linville@tuxdriver.com>
To: Bob Copeland <me@bobcopeland.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
henk@god.dyndns.org, linux-wireless@vger.kernel.org,
ath5k-devel@lists.ath5k.org, jirislaby@gmail.com,
mickflemm@gmail.com, lrodriguez@atheros.com
Subject: Re: [PATCH] ath5k: disable beacon interrupt when interface is down
Date: Wed, 3 Jun 2009 13:48:33 -0400 [thread overview]
Message-ID: <20090603174833.GE3317@tuxdriver.com> (raw)
In-Reply-To: <20090603122251.GA5117@hash.localnet>
On Wed, Jun 03, 2009 at 08:22:51AM -0400, Bob Copeland wrote:
> On Wed, Jun 03, 2009 at 09:09:04AM +0200, Johannes Berg wrote:
> > On Tue, 2009-06-02 at 23:03 -0400, Bob Copeland wrote:
> > > When we remove the active interface, there's no need to continue
> > > sending beacons; doing so would cause a null pointer deref in
> > > ieee80211_beacon_get(). Disable the interrupt in remove_interface
> > > and add a WARN_ON(!vif) in case there are other instances lurking.
> >
> > There's a beacon_enabled setting passed in from mac80211, you should
> > just use that?
>
> Hmm, yeah, I didn't know that. I'll check it out.
I'll take this one for now, and you can send a better one on top when
you're ready.
Thanks,
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2009-06-03 18:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-03 3:03 [PATCH] ath5k: disable beacon interrupt when interface is down Bob Copeland
2009-06-03 7:09 ` Johannes Berg
2009-06-03 12:22 ` Bob Copeland
2009-06-03 17:48 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090603174833.GE3317@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=henk@god.dyndns.org \
--cc=jirislaby@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).