From: Michael Buesch <mb@bu3sch.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [RFC V2] b43/legacy: port to cfg80211 rfkill
Date: Fri, 5 Jun 2009 21:01:46 +0200 [thread overview]
Message-ID: <200906052101.47168.mb@bu3sch.de> (raw)
In-Reply-To: <4a2961a7.RxVbjEA4JdOf01BF%Larry.Finger@lwfinger.net>
On Friday 05 June 2009 20:19:19 Larry Finger wrote:
> From: Johannes Berg <johannes@sipsolutions.net>
>
> This ports the b43/legacy rfkill code to the new API offered
> by cfg80211 and thus removes a lot of useless stuff.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Michael Buesch <mb@bu3sch.de>
> ---
>
> V1 - Original by Johannes.
> V2 - Modified in testing by Larry.
> The rfkill polling routine brings the interface back to the initialized
> state if it is found to be uninitialized. This way the rfkill switch
> may be interpreted. In addition, the radio LED is not turned on in the
> initialization routine unless the rfkill switch is on.
This is pretty silly behavior IMO. Just to bring it to the point:
We initialize a huge wireless MAC, PHY and Radio that consume several watts of power
just to poll a silly RF-kill bit.
We can't we just accept that the RF-kill status is unknown while the device is down?
I really do hate all that rfkill crap and I'm still refusing to sign off on anything that's
related to rfkill (like I did for the past year or so). If people want this merged,
somebody else maintain and sign it off, please.
--
Greetings, Michael.
next prev parent reply other threads:[~2009-06-05 19:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 18:19 [RFC V2] b43/legacy: port to cfg80211 rfkill Larry Finger
2009-06-05 19:01 ` Michael Buesch [this message]
2009-06-05 21:20 ` Larry Finger
2009-06-05 21:38 ` Michael Buesch
2009-06-05 22:32 ` Johannes Berg
2009-06-06 9:34 ` Michael Buesch
2009-06-06 17:38 ` Johannes Berg
2009-06-05 22:38 ` Larry Finger
2009-06-06 9:38 ` Michael Buesch
2009-06-06 17:38 ` Johannes Berg
2009-06-06 17:37 ` Johannes Berg
2009-06-06 17:44 ` Johannes Berg
2009-06-06 18:00 ` Michael Buesch
2009-06-07 12:55 ` Larry Finger
2009-06-06 17:42 ` Johannes Berg
2009-06-06 17:49 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906052101.47168.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Larry.Finger@lwfinger.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).