From: Michael Buesch <mb@bu3sch.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Larry Finger <Larry.Finger@lwfinger.net>, linux-wireless@vger.kernel.org
Subject: Re: [RFC V2] b43/legacy: port to cfg80211 rfkill
Date: Sat, 6 Jun 2009 11:34:47 +0200 [thread overview]
Message-ID: <200906061134.47483.mb@bu3sch.de> (raw)
In-Reply-To: <1244241126.15640.3.camel@johannes.local>
On Saturday 06 June 2009 00:32:06 Johannes Berg wrote:
> On Fri, 2009-06-05 at 23:38 +0200, Michael Buesch wrote:
>
> > Hell, just return a freaking error from b43_rfkill_poll(), if the interface
> > is down. If rfkill can't handle that, it should probably be taught to handle it.
> > Especially as there can be other errors as well, like memory allocation failures.
>
> Be my guest. You'll notice eventually that it's not really easy or
> possible to do. I've explained the currently broken scenario already.
> And even if you introduce the 'unknown' state, you still end up having
> to poll the bit when userspace tries to turn on the device... doesn't
> help much.
It is OK to poll the bit while the device is supposed to be on. But it's not
OK to turn it on to check the bit.
> Larry, thanks for your patch, I'll modify it to turn off the core again
> after checking the rfkill bit tomorrow.
How frequent will that polling happen?
--
Greetings, Michael.
next prev parent reply other threads:[~2009-06-06 9:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 18:19 [RFC V2] b43/legacy: port to cfg80211 rfkill Larry Finger
2009-06-05 19:01 ` Michael Buesch
2009-06-05 21:20 ` Larry Finger
2009-06-05 21:38 ` Michael Buesch
2009-06-05 22:32 ` Johannes Berg
2009-06-06 9:34 ` Michael Buesch [this message]
2009-06-06 17:38 ` Johannes Berg
2009-06-05 22:38 ` Larry Finger
2009-06-06 9:38 ` Michael Buesch
2009-06-06 17:38 ` Johannes Berg
2009-06-06 17:37 ` Johannes Berg
2009-06-06 17:44 ` Johannes Berg
2009-06-06 18:00 ` Michael Buesch
2009-06-07 12:55 ` Larry Finger
2009-06-06 17:42 ` Johannes Berg
2009-06-06 17:49 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906061134.47483.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Larry.Finger@lwfinger.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).