From: Bob Copeland <me@bobcopeland.com>
To: Tobias Doerffel <tobias.doerffel@gmail.com>
Cc: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org
Subject: Re: [ath5k-devel] [PATCH] ath5k: added cfg80211 based rfkill support
Date: Sun, 7 Jun 2009 11:07:55 -0400 [thread overview]
Message-ID: <20090607150755.GA19635@hash.localnet> (raw)
In-Reply-To: <1244374833-11987-1-git-send-email-tobias.doerffel@gmail.com>
On Sun, Jun 07, 2009 at 01:40:33PM +0200, Tobias Doerffel wrote:
> +/*
> + * Read RFKILL GPIO configuration from eeprom
> + */
> +void ath5k_eeprom_read_rfkill(struct ath5k_hw *ah, u16 *gpio, u8 *polarity)
> +{
> + u16 data;
> +
> + ath5k_hw_eeprom_read(ah, AR5K_EEPROM_RFKILL_GPIO_SEL, &data);
> + *gpio = AR5K_REG_MS(data, AR5K_EEPROM_RFKILL_GPIO_SEL);
> +
> + ath5k_hw_eeprom_read(ah, AR5K_EEPROM_RFKILL_POLARITY, &data);
> + *polarity = AR5K_REG_MS(data, AR5K_EEPROM_RFKILL_POLARITY);
> +}
ath5k_eeprom_init_header already reads these values and stuffs them
in the ath5k_eeprom_info struct - you can just use them from there.
Otherwise, mod Johanne's comment, looks great! Thanks for handling
this.
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2009-06-07 15:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-07 11:40 [PATCH] ath5k: added cfg80211 based rfkill support Tobias Doerffel
2009-06-07 12:28 ` Johannes Berg
2009-06-07 15:07 ` Bob Copeland [this message]
2009-06-09 15:33 ` Tobias Doerffel
2009-06-09 18:26 ` Bob Copeland
2009-06-09 19:00 ` John W. Linville
2009-06-09 19:19 ` Bob Copeland
2009-06-10 3:43 ` [PATCH] ath5k: minor rfkill cleanup Bob Copeland
2009-06-09 21:31 ` [PATCH] ath5k: added cfg80211 based rfkill support Tobias Doerffel
2009-06-09 21:57 ` [ath5k-devel] " Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090607150755.GA19635@hash.localnet \
--to=me@bobcopeland.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tobias.doerffel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox