From: Sergey Lapin <slapin@ossfans.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Miller <davem@davemloft.net>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH 2/5] net: add IEEE 802.15.4 socket family implementation
Date: Mon, 8 Jun 2009 02:36:20 +0400 [thread overview]
Message-ID: <20090607223620.GA9606@build.ossfans.org> (raw)
In-Reply-To: <20090607062543.GA10730@uranus.ravnborg.org>
On Sun, Jun 07, 2009 at 08:25:43AM +0200, Sam Ravnborg wrote:
> > --- /dev/null
> > +++ b/net/ieee802154/Makefile
> > @@ -0,0 +1,4 @@
> > +obj-$(CONFIG_IEEE802154) += af_802154.o
> > +af_802154-objs := af_ieee802154.o raw.o dgram.o
> > +
> > +EXTRA_CFLAGS += -Wall -DDEBUG
>
> Please change this to following style:
> > +obj-$(CONFIG_IEEE802154) += af_802154.o
> > +af_802154-y := af_ieee802154.o raw.o dgram.o
> > +
> > +ccflags-y += -Wall -DDEBUG
Ok, I'll re-submit whole request monday night hoping to get some more
review. Thanks!
S.
next prev parent reply other threads:[~2009-06-07 22:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-07 1:18 [PATCH 0/5] IEEE 802.15.4 stack: generic parts v3 Sergey Lapin
2009-06-07 1:18 ` [PATCH 1/5] Add constants for the ieee 802.15.4 stack Sergey Lapin
2009-06-07 1:18 ` [PATCH 2/5] net: add IEEE 802.15.4 socket family implementation Sergey Lapin
2009-06-07 6:25 ` Sam Ravnborg
2009-06-07 22:36 ` Sergey Lapin [this message]
2009-06-07 1:18 ` [PATCH 3/5] net: add NL802154 interface for configuration of 802.15.4 devices Sergey Lapin
2009-06-07 1:18 ` [PATCH 4/5] ieee802154: add documentation about our stack Sergey Lapin
2009-06-07 1:18 ` [PATCH 5/5] ieee802154: add simple HardMAC driver sample Sergey Lapin
2009-06-07 2:23 ` [PULL REQUEST] IEEE 802.15.4 stack: generic parts v3 Sergey Lapin
-- strict thread matches above, loose matches on Subject: below --
2009-06-08 22:18 [PATCH 1/5] Add constants for the ieee 802.15.4 stack Sergey Lapin
2009-06-08 22:18 ` [PULL REQUEST] IEEE 802.15.4 stack: generic parts v4 Sergey Lapin
2009-06-08 22:18 ` [PATCH 2/5] net: add IEEE 802.15.4 socket family implementation Sergey Lapin
2009-06-05 2:29 [PULL REQUEST] IEEE 802.15.4 stack: generic parts v2 Dmitry Eremin-Solenikov
2009-06-05 2:29 ` [PATCH 1/5] Add constants for the ieee 802.15.4 stack Dmitry Eremin-Solenikov
2009-06-05 2:29 ` [PATCH 2/5] net: add IEEE 802.15.4 socket family implementation Dmitry Eremin-Solenikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090607223620.GA9606@build.ossfans.org \
--to=slapin@ossfans.org \
--cc=davem@davemloft.net \
--cc=dbaryshkov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).