Re: [PATCH] ath5k: added cfg80211 based rfkill support

["John W. Linville" <linville@tuxdriver.com>]

On Tue, Jun 09, 2009 at 02:26:12PM -0400, Bob Copeland wrote:
> On Tue, Jun 9, 2009 at 11:33 AM, Tobias
> Doerffel<tobias.doerffel@gmail.com> wrote:
> 
> > +config ATH5K_RFKILL
> > +       bool "Atheros 5xxx rfkill support"
> > +       depends on ATH5K
> > +       default y
> > +       ---help---
> > +         Include support for enabling/disabling WiFi via rfkill switch
> > +         with Atheros 5xxx cards
> > +
> 
> We can still drop this.
> 
> > +       /* enable interrupt for rfkill switch */
> > +       if (AR5K_EEPROM_HDR_RFKILL(ah->ah_capabilities.cap_eeprom.ee_header)) {
> > +               ath5k_rfkill_set_intr(sc, true);
> > +       }
> 
> Coding style...
> 
> > +       if (AR5K_EEPROM_HDR_RFKILL(ah->ah_capabilities.cap_eeprom.ee_header)) {
> > +               ath5k_rfkill_set_intr(sc, false);
> > +       }
> 
> Ditto..
> 
> > +       /* enable RFKILL when stopping HW so Wifi LED is turned off */
> > +       ath5k_rfkill_enable(sc);
> 
> Odd, but ok :)
> 
> This looks really close and the remaining changes are pretty small.  If
> you want, I can take care of the above and resubmit it with your s-o-b
> so you don't have to go through another respin.

If that is your offer, maybe you could just do your own patch on top?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.