From: Tobias Doerffel <tobias.doerffel@gmail.com>
To: Bob Copeland <me@bobcopeland.com>
Cc: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath5k: added cfg80211 based rfkill support
Date: Tue, 9 Jun 2009 23:31:00 +0200 [thread overview]
Message-ID: <200906092331.01072.tobias.doerffel@gmail.com> (raw)
In-Reply-To: <b6c5339f0906091126k573b8725hf623367abcdcdf1f@mail.gmail.com>
[-- Attachment #1: Type: Text/Plain, Size: 495 bytes --]
Hi,
Am Dienstag, 9. Juni 2009 20:26:12 schrieb Bob Copeland:
> > + /* enable RFKILL when stopping HW so Wifi LED is turned off */
> > + ath5k_rfkill_enable(sc);
>
> Odd, but ok :)
Why odd? As a user if I disable Wifi (i.e. enable rfkill, be it via software
or rfkill switch), I do not want the LED to be active anymore. It also might
have minimal influence on power consumption ;-)
Regarding the other changes I'd agree on an additional patch made up by you.
Toby
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-06-09 21:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-07 11:40 [PATCH] ath5k: added cfg80211 based rfkill support Tobias Doerffel
2009-06-07 12:28 ` Johannes Berg
2009-06-07 15:07 ` [ath5k-devel] " Bob Copeland
2009-06-09 15:33 ` Tobias Doerffel
2009-06-09 18:26 ` Bob Copeland
2009-06-09 19:00 ` John W. Linville
2009-06-09 19:19 ` Bob Copeland
2009-06-10 3:43 ` [PATCH] ath5k: minor rfkill cleanup Bob Copeland
2009-06-09 21:31 ` Tobias Doerffel [this message]
2009-06-09 21:57 ` [ath5k-devel] [PATCH] ath5k: added cfg80211 based rfkill support Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906092331.01072.tobias.doerffel@gmail.com \
--to=tobias.doerffel@gmail.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).