[PATCH] rfkill: include err.h

[PATCH] rfkill: include err.h

[Johannes Berg]

Since we use ERR_PTR and similar macros, we need to include linux/err.h.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
 include/linux/rfkill.h |    1 +
 1 file changed, 1 insertion(+)

--- wireless-testing.orig/include/linux/rfkill.h	2009-06-09 15:55:06.000000000 +0200
+++ wireless-testing/include/linux/rfkill.h	2009-06-09 15:55:20.000000000 +0200
@@ -105,6 +105,7 @@ enum rfkill_user_states {
 #include <linux/mutex.h>
 #include <linux/device.h>
 #include <linux/leds.h>
+#include <linux/err.h>
 
 /* this is opaque */
 struct rfkill;

Re: [PATCH] rfkill: include err.h

[David Miller]

From: Johannes Berg <johannes@sipsolutions.net>
Date: Tue, 09 Jun 2009 15:56:52 +0200

> Since we use ERR_PTR and similar macros, we need to include linux/err.h.
> 
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>

I'm applying this directly to net-next-2.6 to fix the -next
build.

Please submit the more critical build fixes for regressions
introduced by the wireless tree direclty to me in the future
thanks.

Re: [PATCH] rfkill: include err.h

[John W. Linville]

On Tue, Jun 09, 2009 at 05:49:52PM -0700, David Miller wrote:
> From: Johannes Berg <johannes@sipsolutions.net>
> Date: Tue, 09 Jun 2009 15:56:52 +0200
> 
> > Since we use ERR_PTR and similar macros, we need to include linux/err.h.
> > 
> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> 
> I'm applying this directly to net-next-2.6 to fix the -next
> build.
> 
> Please submit the more critical build fixes for regressions
> introduced by the wireless tree direclty to me in the future
> thanks.

That's a fine policy -- no objection.  However, please be aware that
Stephen picks-up stuff from the wireless trees even when I haven't
yet asked Dave to pull (so Dave might not always have the patch that
causes the break).  So, just keep that in mind (and CC me as well,
please). :-)

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: [PATCH] rfkill: include err.h

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]

On Tue, 2009-06-09 at 21:34 -0400, John W. Linville wrote:
> On Tue, Jun 09, 2009 at 05:49:52PM -0700, David Miller wrote:
> > From: Johannes Berg <johannes@sipsolutions.net>
> > Date: Tue, 09 Jun 2009 15:56:52 +0200
> > 
> > > Since we use ERR_PTR and similar macros, we need to include linux/err.h.
> > > 
> > > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> > 
> > I'm applying this directly to net-next-2.6 to fix the -next
> > build.
> > 
> > Please submit the more critical build fixes for regressions
> > introduced by the wireless tree direclty to me in the future
> > thanks.
> 
> That's a fine policy -- no objection.  However, please be aware that
> Stephen picks-up stuff from the wireless trees even when I haven't
> yet asked Dave to pull (so Dave might not always have the patch that
> causes the break).  So, just keep that in mind (and CC me as well,
> please). :-)

Alright, I'll do my best to differentiate based on what's in whose
tree :)

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]