Re: [PATCH 0/2] ar9170: 1-stage firmware support / AVM fritz

["Luis R. Rodriguez" <lrodriguez@atheros.com>]

On Mon, Jun 15, 2009 at 12:54:20PM -0700, Marcel Holtmann wrote:
> Hi Luis,
> 
> > >> > > This series now works for me on my WNDA31000, it took a newer shiny
> > >> > > 1-stage firmware to work. I'll push the firmware into linux-firmware
> > >> > > next.
> > >> > >
> > >> > > Should work with the AVM Fritz devices now, haven't tested it but
> > >> > > I think it should work.
> > >> >
> > >> > I happened to have one of these AVM devices. With ar9170.fw firmware it
> > >> > does work fine with the other ones it doesn't.
> > >>
> > >> Excellent, that was the idea behind the patch, to enable these
> > >> devices. Thanks for testing.
> > >>
> > >> > The ar9170.fw is still not in linux-firmware.git, any reason for that?
> > >>
> > >> Yes, the patch I sent to David has some funk as objcopy to ihex seems
> > >> to have some trailing white space. I sent a new patch to him without
> > >> the ihex file though.
> > >>
> > >> > Also since ar9170-1.fw and ar9170-2.fw are not working at all,
> > >>
> > >> They work, they won't work for the AVM device though.
> > >>
> > >> > we better
> > >> > not even try and give the user a crypted error message that the device
> > >> > is in a bad state. Just printk that the firmware might be too old.
> > >>
> > >> Agreed, but as I sent the patch in we *require* the 1-stage firmware
> > >> for the AVM devices, if that is not present we should be bailing out.
> > >> Is that not what happens?
> > >
> > > nope, it tries ar9170-1.fw and then tries to load that and fails with a
> > > timeout (-110) and a weird message that the device might be in a bad
> > > state.
> >
> > Oh interesting, hm, ok doe sit go into a loop with that?
> 
> it bails out of probe, but with are crypted error message. And in the
> end it should not even try the other firmware files if it is an AVM
> device since we know they won't work. So lets give a proper error
> message and bail out.

Heh yeah that was the goal.

  Luis