linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: reinette chatre <reinette.chatre@intel.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	Kalle Valo <kalle.valo@nokia.com>, "Zhu, Yi" <yi.zhu@intel.com>,
	"j@w1.fi" <j@w1.fi>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"ipw3945-devel@lists.sourceforge.net"
	<ipw3945-devel@lists.sourceforge.net>,
	"Abbas, Mohamed" <mohamed.abbas@intel.com>,
	"ath9k-devel@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>
Subject: Re: [ath9k-devel] [PATCH] mac80211: disassociate when switching bands  and not scanning
Date: Thu, 18 Jun 2009 11:28:31 -0700	[thread overview]
Message-ID: <20090618182831.GA2028@tesla> (raw)
In-Reply-To: <1245340021.24303.302.camel@rc-desk>

On Thu, Jun 18, 2009 at 08:47:01AM -0700, reinette chatre wrote:
> Hi John,
> 
> On Thu, 2009-06-18 at 08:01 -0700, John W. Linville wrote:
> > On Thu, Jun 11, 2009 at 01:50:07PM -0700, reinette chatre wrote:
> >
> > > I ran the steps to reproduce on a kernel that is the latest
> > > wireless-testing + "mac80211: disconnect when user changes channel" +
> > > "iwlwifi: remove rs_get_rate workaround". Unfortunately I still get the
> > > rs_get_rate warning.
> >
> > Should I merge the ath9k rate series w/o "iwlwifi: remove rs_get_rate
> > workaround"?
> 
> The later patch "mac80211: add helper for management / no-ack frame rate
> decision" also touches iwlwifi and assumes that "iwlwifi: remove
> rs_get_rate workaround" has been applied.
> 
> I do not know if Luis would want that patch to go in because the warning
> we get may not be specific to iwlwifi. If you do want that to go in then
> please remove the iwlwifi bits.

I don't believe the warning you got were iwlwifi specific, I confirmed it and
I was able to reproduce with ath9k and I also sent a patch to correct it. I'd hate
to see a work around be kept for them and the issue not addressed properly,
which is what this has been trying to address.

Mind you the patch I sent conflicts with johills patch but I figured we can
just implement a proper patch to fix that warning afterwards.

  Luis

  reply	other threads:[~2009-06-18 18:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-10 20:35 [PATCH] mac80211: disassociate when switching bands and not scanning Luis R. Rodriguez
2009-06-10 20:49 ` reinette chatre
2009-06-10 20:49   ` Luis R. Rodriguez
2009-06-10 21:03     ` reinette chatre
2009-06-10 21:04       ` [ath9k-devel] " Luis R. Rodriguez
2009-06-10 21:07         ` Johannes Berg
2009-06-10 22:42           ` Luis R. Rodriguez
2009-06-10 22:44             ` Luis R. Rodriguez
2009-06-11 19:04               ` Luis R. Rodriguez
2009-06-11 19:10                 ` Johannes Berg
2009-06-11 20:54                   ` Luis R. Rodriguez
2009-06-11 20:50                 ` reinette chatre
2009-06-18 15:01                   ` John W. Linville
2009-06-18 15:47                     ` reinette chatre
2009-06-18 18:28                       ` Luis R. Rodriguez [this message]
2009-06-18 18:44                         ` reinette chatre
2009-06-18 18:42                           ` Luis R. Rodriguez
2009-06-10 21:06       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090618182831.GA2028@tesla \
    --to=lrodriguez@atheros.com \
    --cc=Luis.Rodriguez@Atheros.com \
    --cc=ath9k-devel@lists.ath9k.org \
    --cc=ipw3945-devel@lists.sourceforge.net \
    --cc=j@w1.fi \
    --cc=johannes@sipsolutions.net \
    --cc=kalle.valo@nokia.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mohamed.abbas@intel.com \
    --cc=reinette.chatre@intel.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).