From: "John W. Linville" <linville@tuxdriver.com>
To: Dave <kilroyd@googlemail.com>
Cc: linux-wireless@vger.kernel.org, orinoco-devel@lists.sourceforge.net
Subject: Re: [PATCH 21/23] orinoco: convert scanning to cfg80211
Date: Fri, 19 Jun 2009 14:02:34 -0400 [thread overview]
Message-ID: <20090619180233.GD2753@tuxdriver.com> (raw)
In-Reply-To: <4A3BD06D.7080702@gmail.com>
On Fri, Jun 19, 2009 at 06:52:45PM +0100, Dave wrote:
> John W. Linville wrote:
> > On Thu, Jun 18, 2009 at 11:21:33PM +0100, David Kilroy wrote:
> >> This removes the custom scan cache used by orinoco.
> >>
> >> We also have to avoid calling cfg80211_scan_done from the hard
> >> interrupt, so we offload the entirety of scan processing to a workqueue.
> >>
> >> This may behave strangely if you start scanning just prior to
> >> suspending...
> >>
> >> Signed-off-by: David Kilroy <kilroyd@googlemail.com>
> >
> > Hmmm...please do try to compile test patches before posting! :-)
> >
> > John
>
> Compile? I'm running it! (and sparse didn't complain either)
>
> I'll go have a look see what's special on my end. I'm guessing no SMP or
> something.
Haha...yeah, that's probably it...
> Would you like the series/patch reposted including this fix?
No, I've got it fixed.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2009-06-19 18:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 22:21 [PATCH 00/23] orinoco: initiate cfg80211 conversion David Kilroy
2009-06-18 22:21 ` [PATCH 01/23] cfg80211: add wrapper function to get wiphy from priv pointer David Kilroy
2009-06-18 22:21 ` [PATCH 02/23] cfg80211: Advertise ciphers via WE according to driver capability David Kilroy
2009-06-18 23:38 ` Julian Calaby
2009-06-19 17:20 ` Dave
2009-06-20 0:38 ` Julian Calaby
2009-06-18 22:21 ` [PATCH 03/23] cfg80211: allow drivers that can't scan for specific ssids David Kilroy
2009-06-18 22:21 ` [PATCH 04/23] cfg80211: set WE encoding size based on available ciphers David Kilroy
2009-06-18 22:21 ` [PATCH 05/23] cfg80211: infer WPA and WPA2 support from TKIP and CCMP David Kilroy
2009-06-18 22:21 ` [PATCH 06/23] orinoco: Move firmware capability determination into hw.c David Kilroy
2009-06-18 22:21 ` [PATCH 07/23] orinoco: Move card reading code " David Kilroy
2009-06-18 22:21 ` [PATCH 08/23] orinoco: Move FID allocation to hw.c David Kilroy
2009-06-18 22:21 ` [PATCH 09/23] orinoco: use dev_err in early initialisation routines David Kilroy
2009-06-18 22:21 ` [PATCH 10/23] orinoco: firmware helpers should use dev_err and friends David Kilroy
2009-06-18 22:21 ` [PATCH 11/23] orinoco: Replace net_device with orinoco_private in driver interfaces David Kilroy
2009-06-18 22:21 ` [PATCH 12/23] orinoco: initialise independently of netdev David Kilroy
2009-06-18 22:21 ` [PATCH 13/23] orinoco: Change set_tkip to use orinoco_private instead of hermes_t David Kilroy
2009-06-18 22:21 ` [PATCH 14/23] orinoco: initiate cfg80211 conversion David Kilroy
2009-06-18 22:21 ` [PATCH 15/23] orinoco: make firmware download less verbose David Kilroy
2009-06-18 22:21 ` [PATCH 16/23] orinoco: move netdev interface creation to main driver David Kilroy
2009-06-18 22:21 ` [PATCH 17/23] airport: store irq in card private structure David Kilroy
2009-06-18 22:21 ` [PATCH 18/23] orinoco: Handle suspend/restore in core driver David Kilroy
2009-06-18 22:21 ` [PATCH 19/23] orinoco: provide generic commit function David Kilroy
2009-06-18 22:21 ` [PATCH 20/23] orinoco: convert mode setting to cfg80211 David Kilroy
2009-06-18 22:21 ` [PATCH 21/23] orinoco: convert scanning " David Kilroy
2009-06-19 17:35 ` John W. Linville
2009-06-19 17:52 ` Dave
2009-06-19 18:02 ` John W. Linville [this message]
2009-06-19 21:25 ` Dave
2009-06-18 22:21 ` [PATCH 22/23] orinoco: convert giwrange " David Kilroy
2009-06-18 22:21 ` [PATCH 23/23] orinoco: remove WE nickname support David Kilroy
2009-06-18 22:52 ` [PATCH 00/23] orinoco: initiate cfg80211 conversion Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090619180233.GD2753@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=kilroyd@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=orinoco-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).