* ar9170usb and module link in sysfs?
@ 2009-06-19 17:54 Andrey Yurovsky
2009-06-20 3:10 ` [PATCH] ar9170usb: module link in sysfs Christian Lamparter
0 siblings, 1 reply; 2+ messages in thread
From: Andrey Yurovsky @ 2009-06-19 17:54 UTC (permalink / raw)
To: linux-wireless
I'm curious about the ar9170usb driver and its 'module' links (or
rather, lack there of) in sysfs. For other drivers, I can look up a
wlanN interface's module by doing looking at
device/driver/module/drivers:
# ls /sys/class/net/wlan0/device/driver/module/drivers/
pci:ath5k
# ls /sys/class/net/wlan1/device/driver/module/drivers/
usb:zd1211rw
For ar9170usb, the driver directory doesn't have a module subdirectory
and I can't seem to find a link to /sys/bus/usb/drivers/ar9170usb via
/sys/class/wlanN like I'd expect to. Is this normal or does ar9170usb
do something different with respect to sysfs that I'm missing?
Thanks,
-Andrey
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] ar9170usb: module link in sysfs
2009-06-19 17:54 ar9170usb and module link in sysfs? Andrey Yurovsky
@ 2009-06-20 3:10 ` Christian Lamparter
0 siblings, 0 replies; 2+ messages in thread
From: Christian Lamparter @ 2009-06-20 3:10 UTC (permalink / raw)
To: Andrey Yurovsky; +Cc: linux-wireless, John W. Linville
Andrey Yurovsky reported that the driver forwarded erroneously the
parent device structure instead of the real thing, which of course
led to some dodgy sysfs links (at least?).
Signed-off-by: Christian Lamparter <chunkeey@web.de>
---
your usb(core) subsystem is probably built-in (rather than a module?),
so you won't have a "module" entry there.
BTW: currently, I don't have a device, please test!
---
diff --git a/drivers/net/wireless/ath/ar9170/usb.c b/drivers/net/wireless/ath/ar9170/usb.c
index 754b1f8..1aec7af 100644
--- a/drivers/net/wireless/ath/ar9170/usb.c
+++ b/drivers/net/wireless/ath/ar9170/usb.c
@@ -779,7 +779,7 @@ static int ar9170_usb_probe(struct usb_interface *intf,
aru->req_one_stage_fw = ar9170_requires_one_stage(id);
usb_set_intfdata(intf, aru);
- SET_IEEE80211_DEV(ar->hw, &udev->dev);
+ SET_IEEE80211_DEV(ar->hw, &intf->dev);
init_usb_anchor(&aru->rx_submitted);
init_usb_anchor(&aru->tx_pending);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-20 3:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-19 17:54 ar9170usb and module link in sysfs? Andrey Yurovsky
2009-06-20 3:10 ` [PATCH] ar9170usb: module link in sysfs Christian Lamparter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).