From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 8/8 v3] mac80211: re-add HT disabling
Date: Tue, 30 Jun 2009 18:55:48 +0530 [thread overview]
Message-ID: <20090630132547.GB24667@vasanth-laptop> (raw)
In-Reply-To: <20090630115303.111250594@sipsolutions.net>
On Tue, Jun 30, 2009 at 05:22:53PM +0530, Johannes Berg wrote:
> The IEEE80211_STA_TKIP_WEP_USED flag is used internally to
> disable HT when WEP or TKIP are used. Now that cfg80211 is
> giving us the required information, we can set the flag
> appropriately again.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> net/mac80211/cfg.c | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> --- wireless-testing.orig/net/mac80211/cfg.c 2009-06-30 13:25:43.000000000 +0200
> +++ wireless-testing/net/mac80211/cfg.c 2009-06-30 13:25:45.000000000 +0200
> @@ -1228,7 +1228,7 @@ static int ieee80211_assoc(struct wiphy
> struct cfg80211_assoc_request *req)
> {
> struct ieee80211_sub_if_data *sdata;
> - int ret;
> + int ret, i;
>
> sdata = IEEE80211_DEV_TO_SUB_IF(dev);
>
> @@ -1236,6 +1236,19 @@ static int ieee80211_assoc(struct wiphy
> !(sdata->u.mgd.flags & IEEE80211_STA_AUTHENTICATED))
> return -ENOLINK; /* not authenticated */
>
> + sdata->u.mgd.flags &= ~IEEE80211_STA_TKIP_WEP_USED;
> +
> + if (req->crypto.cipher_group == WLAN_CIPHER_SUITE_WEP40 ||
> + req->crypto.cipher_group == WLAN_CIPHER_SUITE_TKIP ||
> + req->crypto.cipher_group == WLAN_CIPHER_SUITE_WEP104)
> + sdata->u.mgd.flags |= IEEE80211_STA_TKIP_WEP_USED;
No, we have to disable HT only when WEP/TKIP is used as pairwise,
not used as group cipher.
Vasanth
next prev parent reply other threads:[~2009-06-30 13:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-30 11:52 [PATCH 0/8 v3] connect API, wext conversion Johannes Berg
2009-06-30 11:52 ` [PATCH 1/8 v3] cfg80211: connect/disconnect API Johannes Berg
2009-06-30 15:35 ` [PATCH] cfg80211: set conn.state properly in the connect() case Samuel Ortiz
2009-07-01 10:58 ` Johannes Berg
2009-06-30 15:45 ` [PATCH RFC] iwmc3200wifi: connect API port Samuel Ortiz
2009-06-30 11:52 ` [PATCH 2/8 v3] cfg80211: emulate connect with auth/assoc Johannes Berg
2009-06-30 11:52 ` [PATCH 3/8 v3] cfg80211: managed mode wext compatibility Johannes Berg
2009-06-30 11:52 ` [PATCH 4/8 v3] cfg80211: implement iwpower Johannes Berg
2009-06-30 11:52 ` [PATCH 5/8 v3] cfg80211: implement IWAP for WDS Johannes Berg
2009-06-30 11:52 ` [PATCH 6/8 v3] cfg80211: implement IWRATE Johannes Berg
2009-06-30 11:52 ` [PATCH 7/8 v3] cfg80211: implement get_wireless_stats Johannes Berg
2009-06-30 11:52 ` [PATCH 8/8 v3] mac80211: re-add HT disabling Johannes Berg
2009-06-30 13:25 ` Vasanthakumar Thiagarajan [this message]
2009-06-30 13:37 ` Johannes Berg
2009-06-30 13:52 ` Vasanthakumar Thiagarajan
2009-06-30 14:00 ` Johannes Berg
2009-07-01 7:39 ` [PATCH 8/8 v3.1] " Johannes Berg
2009-07-01 10:13 ` Vasanthakumar Thiagarajan
2009-07-01 10:42 ` Johannes Berg
2009-07-02 9:51 ` Jouni Malinen
2009-07-02 9:53 ` Johannes Berg
2009-07-02 11:43 ` Jouni Malinen
2009-07-02 11:56 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090630132547.GB24667@vasanth-laptop \
--to=vasanth@atheros.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).