From: Max Filippov <jcmvbkbc@gmail.com>
To: Christian Lamparter <chunkeey@web.de>
Cc: "linux-wireless" <linux-wireless@vger.kernel.org>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] p54: two endian fixes
Date: Sat, 4 Jul 2009 17:39:16 +0400 [thread overview]
Message-ID: <200907041739.18354.jcmvbkbc@gmail.com> (raw)
In-Reply-To: <200907032101.15855.chunkeey@web.de>
> This patch fixes all CHECK_ENDIAN complains:
>
> 1. p54/fwio.c:296:6: warning: restricted __le32 degrades to integer
> p54/fwio.c:296:6: warning: restricted __le32 degrades to integer
>
> 2. p54/p54spi.c:172:32: warning: incorrect type in initializer
> p54spi.c:172:32: expected restricted __le32 [usertype] buffer
> p54/p54spi.c:172:32: got unsigned int
>
> Signed-off-by: Christian Lamparter <chunkeey@web.de>
> ---
> Max,
>
> drivers/net/wireless/p54/p54spi.c:115: warning: ‘p54spi_read16’ defined but not used
>
> looks like this function can be nuked, or do you have plans with it?
No, no plans. Also there's unused p54spi_registers_array, which seems to be cx3110x legacy.
> for (i = 0; i < 2000; i++) {
> - __le32 buffer = p54spi_read32(priv, reg);
> + u32 buffer = p54spi_read32(priv, reg);
> if ((buffer & bits) == bits)
> return 1;
> }
You're right, my fault. There used to be p54spi_spi_read here, which didn't convert endianness.
Thanks.
-- Max
prev parent reply other threads:[~2009-07-04 13:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-03 19:01 [PATCH] p54: two endian fixes Christian Lamparter
2009-07-04 13:39 ` Max Filippov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907041739.18354.jcmvbkbc@gmail.com \
--to=jcmvbkbc@gmail.com \
--cc=chunkeey@web.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).