From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Bob Copeland <me@bobcopeland.com>,
linville@tuxdriver.com, mickflemm@gmail.com,
lrodriguez@atheros.com, linux-wireless@vger.kernel.org,
ath5k-devel@lists.ath5k.org
Subject: Re: [PATCH 4/5] ath5k: do not release irq across suspend/resume
Date: Sat, 4 Jul 2009 23:37:58 +0200 [thread overview]
Message-ID: <200907042337.59470.rjw@sisk.pl> (raw)
In-Reply-To: <4A4FC889.9000401@gmail.com>
On Saturday 04 July 2009, Jiri Slaby wrote:
> On 07/04/2009 06:59 PM, Bob Copeland wrote:
> > Paraphrasing Rafael J. Wysocki: "drivers should not release PCI IRQs
> > in suspend." Doing so causes a warning during suspend/resume on some
> > platforms.
>
> Hmm, I added it because I was told an irq can change over suspend (or at
> least it could in the past). I think it's not true anymore, since we
> would have serious problems with the code all over the tree.
>
> I can't find where Rafael uttered those words above, do you have a link?
Someone recently asked on a mailing list (unfortunately I can't recall
which one) if drivers should release irqs over suspend.
The answer was more-or-less that drivers are not expected to do that and it
really is not recommended. In fact, we do the whole suspend_device_irqs()
thing, because the drivers are expected not to do that.
Best,
Rafael
next prev parent reply other threads:[~2009-07-04 21:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-04 16:59 [PATCH 0/5] ath5k updates Bob Copeland
2009-07-04 16:59 ` [PATCH 1/5] ath5k: send buffered frames after the beacon Bob Copeland
2009-07-04 16:59 ` [PATCH 2/5] ath5k: rework beacon configuration Bob Copeland
2009-07-04 16:59 ` [PATCH 3/5] ath: remove unnecessary return in ath_regd_get_band_ctl Bob Copeland
2009-07-04 16:59 ` [PATCH 4/5] ath5k: do not release irq across suspend/resume Bob Copeland
2009-07-04 21:24 ` Jiri Slaby
2009-07-04 21:37 ` Rafael J. Wysocki [this message]
2009-07-05 11:53 ` Bob Copeland
2009-07-04 16:59 ` [PATCH 5/5] ath5k: write PCU registers on initial reset Bob Copeland
2009-07-04 18:40 ` Felix Fietkau
2009-07-05 0:41 ` Bob Copeland
2009-07-05 1:03 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907042337.59470.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).