From: Bob Copeland <me@bobcopeland.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linville@tuxdriver.com, jirislaby@gmail.com, mickflemm@gmail.com,
lrodriguez@atheros.com, linux-wireless@vger.kernel.org,
ath5k-devel@lists.ath5k.org, stable@kernel.org
Subject: [PATCH 5/5] ath5k: write PCU registers on initial reset
Date: Sat, 4 Jul 2009 21:03:13 -0400 [thread overview]
Message-ID: <20090705010313.GB2132@hash.localnet> (raw)
In-Reply-To: <4A4FA224.40006@openwrt.org>
Commit d7dc100374df0c21afd8a198336ecd7999697159, "Ath5k: unify resets"
introduced a regression into 2.6.28 where the PCU registers are never
initialized, due to ath5k_reset() always passing true for change_channel.
We subsequently program a lot of these registers but several may start
in an unknown state.
Cc: stable@kernel.org
Reported-by: Forrest Zhang <forrest@hifulltech.com>
Signed-off-by: Bob Copeland <me@bobcopeland.com>
---
v2, without dumb thinko
drivers/net/wireless/ath/ath5k/base.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index 3f55e90..80ae38d 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -2687,7 +2687,7 @@ ath5k_reset(struct ath5k_softc *sc, struct ieee80211_channel *chan)
sc->curchan = chan;
sc->curband = &sc->sbands[chan->band];
}
- ret = ath5k_hw_reset(ah, sc->opmode, sc->curchan, true);
+ ret = ath5k_hw_reset(ah, sc->opmode, sc->curchan, chan != NULL);
if (ret) {
ATH5K_ERR(sc, "can't reset hardware (%d)\n", ret);
goto err;
--
1.6.2.5
prev parent reply other threads:[~2009-07-05 1:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-04 16:59 [PATCH 0/5] ath5k updates Bob Copeland
2009-07-04 16:59 ` [PATCH 1/5] ath5k: send buffered frames after the beacon Bob Copeland
2009-07-04 16:59 ` [PATCH 2/5] ath5k: rework beacon configuration Bob Copeland
2009-07-04 16:59 ` [PATCH 3/5] ath: remove unnecessary return in ath_regd_get_band_ctl Bob Copeland
2009-07-04 16:59 ` [PATCH 4/5] ath5k: do not release irq across suspend/resume Bob Copeland
2009-07-04 21:24 ` Jiri Slaby
2009-07-04 21:37 ` Rafael J. Wysocki
2009-07-05 11:53 ` Bob Copeland
2009-07-04 16:59 ` [PATCH 5/5] ath5k: write PCU registers on initial reset Bob Copeland
2009-07-04 18:40 ` Felix Fietkau
2009-07-05 0:41 ` Bob Copeland
2009-07-05 1:03 ` Bob Copeland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090705010313.GB2132@hash.localnet \
--to=me@bobcopeland.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=mickflemm@gmail.com \
--cc=nbd@openwrt.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).