From: David Miller <davem@davemloft.net>
To: chunkeey@web.de
Cc: Larry.Finger@lwfinger.net, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] p54: Fix regression in 2.6.31-rcX since commit a1091aa - sleeping function called from invalid context
Date: Mon, 06 Jul 2009 12:34:41 -0700 (PDT) [thread overview]
Message-ID: <20090706.123441.246532764.davem@davemloft.net> (raw)
In-Reply-To: <200907062119.25642.chunkeey@web.de>
From: Christian Lamparter <chunkeey@web.de>
Date: Mon, 6 Jul 2009 21:19:25 +0200
> On Monday 06 July 2009 21:14:29 David Miller wrote:
>> If I can't figure it out quickly I'll just simply revert.
> hmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmm
> [2.6.31] p54: band-aid to restore driver functionality
> http://patchwork.ozlabs.org/patch/28918/
>
> in case someone missed it.
It is so much cleaner to not do multiple things in one patch.
It's also better to completely revert the SKB list handling
changes first, then add whatever other fixes you want make
on top.
Partial revert really makes no sense here and is only asking
for even more potential regressions.
So, like I said, I'm reverting this wholesale unless I can figure
out a fix quickly.
next prev parent reply other threads:[~2009-07-06 19:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 19:07 [PATCH] p54: Fix regression in 2.6.31-rcX since commit a1091aa - sleeping function called from invalid context Larry Finger
2009-07-06 19:14 ` David Miller
2009-07-06 19:19 ` Christian Lamparter
2009-07-06 19:34 ` David Miller [this message]
2009-07-06 19:43 ` Larry Finger
2009-07-06 19:50 ` David Miller
2009-07-06 20:26 ` Bjarke Istrup Pedersen
2009-07-06 21:36 ` David Miller
2009-07-06 20:42 ` Larry Finger
2009-07-06 21:36 ` David Miller
2009-07-06 20:01 ` Bjarke Istrup Pedersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090706.123441.246532764.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Larry.Finger@lwfinger.net \
--cc=chunkeey@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).