linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Ian Lynagh <igloo@earth.li>
Cc: linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org,
	users@rt2x00.serialmonkey.com
Subject: Re: PROBLEM: USB wlan device stops working; ehci "kernel BUG"
Date: Fri, 10 Jul 2009 10:43:49 -0700	[thread overview]
Message-ID: <200907101043.49869.david-b@pacbell.net> (raw)
In-Reply-To: <20090710143253.GA4133@matrix.chaos.earth.li>

On Friday 10 July 2009, Ian Lynagh wrote:
> [582730.178212] kernel BUG at .../drivers/usb/host/ehci-mem.c:74!

Note that this is a *SECONDARY* failure ... the endpoint hardware
is still in use, but it should have been shut down already.  So
the interesting question is:  what was the *PRIMARY* failure?

So I'd suggest that the WLAN device driver has at least three bugs:

 1 The error logging should use dev_err() etc so that it shows which
   USB device it came from; "phy0 -> rt2x00usb_vendor_request" etc
   just leaves us guessing.

 2 The first one, which prevented it from working and caused
   all the syslog spam that wasn't triggered by seeming bugs
   in userspace code (those "derefnull" and "divbyzero" utils,
   also "ghc"); presumably the PHY code is at least one issue.
   Maybe it's just mis-handling something at high speed...

 3 The driver's likely doing *something wrong* in disconnect().
   Maybe returning while a control message is outstanding; that
   might cause the above BUG(), ISTR there was a hole of that
   shape in the USB stack a few years ago.

I'm skeptical that the BUG() above would trigger without a driver
first misbehaving.  This is not a common BUG(); something else
made it happen.  My guess is #3 above.  The first two seem very
apparent just from looking at the syslog data provided.

- Dave

  parent reply	other threads:[~2009-07-10 17:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-10 14:32 PROBLEM: USB wlan device stops working; ehci "kernel BUG" Ian Lynagh
2009-07-10 15:09 ` Pavel Roskin
2009-07-10 17:03 ` Steve Calfee
2009-07-10 17:43 ` David Brownell [this message]
2009-07-10 17:59   ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907101043.49869.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=igloo@earth.li \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=users@rt2x00.serialmonkey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).