* [PATCH] cfg80211: update misleading comment
@ 2009-07-10 12:54 Helmut Schaa
2009-07-10 13:16 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Helmut Schaa @ 2009-07-10 12:54 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless, Johannes Berg
In cfg80211_scan_request n_channels refers to the total number
of channels to scan. Update the misleading comment accordingly.
Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
---
Maybe the comment is correct and it is just me who thinks it is
misleading ;) but I just stumbled over that.
diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
index dba7874..d458972 100644
--- a/include/net/cfg80211.h
+++ b/include/net/cfg80211.h
@@ -538,7 +538,7 @@ struct cfg80211_ssid {
* @ssids: SSIDs to scan for (active scan only)
* @n_ssids: number of SSIDs
* @channels: channels to scan on.
- * @n_channels: number of channels for each band
+ * @n_channels: total number of channels to scan
* @ie: optional information element(s) to add into Probe Request or %NULL
* @ie_len: length of ie in octets
* @wiphy: the wiphy this was for
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cfg80211: update misleading comment
2009-07-10 12:54 [PATCH] cfg80211: update misleading comment Helmut Schaa
@ 2009-07-10 13:16 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2009-07-10 13:16 UTC (permalink / raw)
To: Helmut Schaa; +Cc: John Linville, linux-wireless
[-- Attachment #1: Type: text/plain, Size: 1092 bytes --]
On Fri, 2009-07-10 at 14:54 +0200, Helmut Schaa wrote:
> In cfg80211_scan_request n_channels refers to the total number
> of channels to scan. Update the misleading comment accordingly.
>
> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
> ---
>
> Maybe the comment is correct and it is just me who thinks it is
> misleading ;) but I just stumbled over that.
Heh, not sure what I was thinking when writing that :)
Acked-by: Johannes Berg <johannes@sipsolutions.net>
> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
> index dba7874..d458972 100644
> --- a/include/net/cfg80211.h
> +++ b/include/net/cfg80211.h
> @@ -538,7 +538,7 @@ struct cfg80211_ssid {
> * @ssids: SSIDs to scan for (active scan only)
> * @n_ssids: number of SSIDs
> * @channels: channels to scan on.
> - * @n_channels: number of channels for each band
> + * @n_channels: total number of channels to scan
> * @ie: optional information element(s) to add into Probe Request or %NULL
> * @ie_len: length of ie in octets
> * @wiphy: the wiphy this was for
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-10 13:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-10 12:54 [PATCH] cfg80211: update misleading comment Helmut Schaa
2009-07-10 13:16 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).