linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: steven@steven676.net (Steven Luo)
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
	Vasanth Thiagarajan <Vasanth.Thiagarajan@Atheros.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"John W. Linville" <linville@tuxdriver.com>,
	Senthilkumar Balasubramanian
	<Senthilkumar.Balasubramanian@Atheros.com>,
	"ath9k-devel@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>,
	Bennyam Malavazi <Bennyam.Malavazi@Atheros.com>,
	Jouni Malinen <Jouni.Malinen@Atheros.com>,
	"Vasanth@venema.h4ckr.net" <Vasanth@venema.h4ckr.net>
Subject: Re: [ath9k-devel] [PATCH] ath9k: Fix enabling OFDM weak signal detection
Date: Tue, 14 Jul 2009 21:04:26 -0700	[thread overview]
Message-ID: <20090715040426.GA14415@steven676.net> (raw)
In-Reply-To: <20090714181148.GE25788@mosca>

On Tue, Jul 14, 2009 at 11:11:48AM -0700, Luis R. Rodriguez wrote:
> On Tue, Jul 14, 2009 at 11:03:48AM -0700, Luis Rodriguez wrote:
> > Please try this patch instead, I've only compile tested this.

Yeah, this works too.  Thanks!

-Steven Luo

> Now without the double AP check :)
> 
> From: Luis R. Rodriguez <lrodriguez@atheros.com>
> Subject: [PATCH] ath9k: Tune ANI function processing on AP mode during ANI reset
> 
> For AP mode we must tune ANI specially for 2 GHz and
> for 5 GHz. We mask in only the flags we want to toggle
> on ath9k_hw_ani_control() through the ah->ani_function
> bitmask, this will take care of ignoring changes during
> ANI reset which we were disabling before.
> 
> Reported-by: Steven Luo <steven@steven676.net>
> Cc: Bennyam Malavazi <Bennyam.Malavazi@Atheros.com
> Cc: Jouni Malinen <Jouni.Malinen@Atheros.com>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
>  drivers/net/wireless/ath/ath9k/ani.c |   12 ++++++++++++
>  1 files changed, 12 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/ani.c b/drivers/net/wireless/ath/ath9k/ani.c
> --- a/drivers/net/wireless/ath/ath9k/ani.c
> +++ b/drivers/net/wireless/ath/ath9k/ani.c
> @@ -478,6 +478,18 @@ void ath9k_ani_reset(struct ath_hw *ah)
>  			"Reset ANI state opmode %u\n", ah->opmode);
>  		ah->stats.ast_ani_reset++;
>  
> +		if (ah->opmode == NL80211_IFTYPE_AP) {
> +			/*
> +			 * ath9k_hw_ani_control() will only process items set on
> +			 * ah->ani_function
> +			 */
> +			if (IS_CHAN_2GHZ(chan))
> +				ah->ani_function = (ATH9K_ANI_SPUR_IMMUNITY_LEVEL |
> +						    ATH9K_ANI_FIRSTEP_LEVEL);
> +			else
> +				ah->ani_function = 0;
> +		}
> +
>  		ath9k_hw_ani_control(ah, ATH9K_ANI_NOISE_IMMUNITY_LEVEL, 0);
>  		ath9k_hw_ani_control(ah, ATH9K_ANI_SPUR_IMMUNITY_LEVEL, 0);
>  		ath9k_hw_ani_control(ah, ATH9K_ANI_FIRSTEP_LEVEL, 0);
> -- 
> 1.6.3.3


  reply	other threads:[~2009-07-15  4:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-09 21:12 [PATCH] ath9k: Fix enabling OFDM weak signal detection Steven Luo
2009-07-10 18:02 ` [ath9k-devel] " Luis R. Rodriguez
2009-07-11 15:23   ` Nick Kossifidis
2009-07-14 18:03   ` Luis R. Rodriguez
2009-07-14 18:11     ` Luis R. Rodriguez
2009-07-15  4:04       ` Steven Luo [this message]
2009-07-11 15:26 ` Nick Kossifidis
2009-07-11 18:48   ` Steven Luo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090715040426.GA14415@steven676.net \
    --to=steven@steven676.net \
    --cc=Bennyam.Malavazi@Atheros.com \
    --cc=Jouni.Malinen@Atheros.com \
    --cc=Senthilkumar.Balasubramanian@Atheros.com \
    --cc=Vasanth.Thiagarajan@Atheros.com \
    --cc=Vasanth@venema.h4ckr.net \
    --cc=ath9k-devel@lists.ath9k.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=lrodriguez@atheros.com \
    --cc=mcgrof@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).