From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath9k-devel@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>
Subject: Re: [PATCH 3/5] cfg80211: add WoW support
Date: Wed, 15 Jul 2009 09:16:00 -0700 [thread overview]
Message-ID: <20090715161600.GF5682@mosca> (raw)
In-Reply-To: <1247673906.10754.14.camel@johannes.local>
On Wed, Jul 15, 2009 at 09:05:06AM -0700, Johannes Berg wrote:
> On Wed, 2009-07-15 at 08:14 -0700, Luis R. Rodriguez wrote:
> > > > + if (!(wiphy->wow_triggers_supported & triggers_requested)) {
> > > > + err = -EOPNOTSUPP;
> > > > + goto out;
> > >
> > > This seems wrong, should be "requested & supported != requested", I
> > > think.
> >
> > The above one won't return -EOPNOTSUPP when you add additional junk, you're
> > right, better to just inform userspace of that.
>
> Your version also disallows turning off WoW again, afaict.
That is something we do want, as otherwise we'll keep the device powered on.
Will consider both.
Luis
next prev parent reply other threads:[~2009-07-15 16:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-15 0:21 [PATCH 0/5] wireless: add wow support Luis R. Rodriguez
2009-07-15 0:21 ` [PATCH 1/5] ath9k: do not stop the queues in driver stop Luis R. Rodriguez
2009-07-15 0:21 ` [PATCH 2/5] adm8211: remove uneeded code during suspend/resume Luis R. Rodriguez
2009-07-15 0:21 ` [PATCH 3/5] cfg80211: add WoW support Luis R. Rodriguez
2009-07-15 11:45 ` Johannes Berg
2009-07-15 15:14 ` Luis R. Rodriguez
2009-07-15 16:05 ` Johannes Berg
2009-07-15 16:16 ` Luis R. Rodriguez [this message]
2009-07-15 16:20 ` Johannes Berg
2009-07-15 16:33 ` Luis R. Rodriguez
2009-07-15 0:21 ` [PATCH 4/5] mac80211: " Luis R. Rodriguez
2009-07-15 11:57 ` Johannes Berg
2009-07-15 15:22 ` Luis R. Rodriguez
2009-07-15 16:03 ` Johannes Berg
2009-07-15 16:18 ` Luis R. Rodriguez
2009-07-15 0:22 ` [PATCH 5/5] ath9k: Add Wake-on-Wireless-LAN support Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090715161600.GF5682@mosca \
--to=lrodriguez@atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=ath9k-devel@lists.ath9k.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).