From: Ivo van Doorn <ivdoorn@gmail.com>
To: Tobias Klauser <klto@zhaw.ch>
Cc: linville@tuxdriver.com, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com
Subject: Re: [PATCH 7/8] rt2x00: Use %pM conversion specifier
Date: Thu, 16 Jul 2009 22:27:30 +0200 [thread overview]
Message-ID: <200907162227.30362.IvDoorn@gmail.com> (raw)
In-Reply-To: <1247734839-21394-1-git-send-email-klto@zhaw.ch>
On Thursday 16 July 2009, Tobias Klauser wrote:
> Use the %pM conversion specifier for printk instead of print_mac.
>
> Signed-off-by: Tobias Klauser <klto@zhaw.ch>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
> ---
> drivers/net/wireless/rt2x00/rt2800usb.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c
> index 3756166..da84afb 100644
> --- a/drivers/net/wireless/rt2x00/rt2800usb.c
> +++ b/drivers/net/wireless/rt2x00/rt2800usb.c
> @@ -2224,10 +2224,8 @@ static int rt2800usb_validate_eeprom(struct rt2x00_dev *rt2x00dev)
> */
> mac = rt2x00_eeprom_addr(rt2x00dev, EEPROM_MAC_ADDR_0);
> if (!is_valid_ether_addr(mac)) {
> - DECLARE_MAC_BUF(macbuf);
> -
> random_ether_addr(mac);
> - EEPROM(rt2x00dev, "MAC: %s\n", print_mac(macbuf, mac));
> + EEPROM(rt2x00dev, "MAC: %pM\n", mac);
> }
>
> rt2x00_eeprom_read(rt2x00dev, EEPROM_ANTENNA, &word);
next prev parent reply other threads:[~2009-07-16 20:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-16 9:00 [PATCH 7/8] rt2x00: Use %pM conversion specifier Tobias Klauser
2009-07-16 20:27 ` Ivo van Doorn [this message]
2009-07-16 20:35 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907162227.30362.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=klto@zhaw.ch \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox