linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Lamparter <chunkeey@web.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	wireless <linux-wireless@vger.kernel.org>
Subject: Re: WARN_ON at minstrel_get_rate (include/net/mac80211.h:2111)
Date: Sat, 18 Jul 2009 19:48:54 +0200	[thread overview]
Message-ID: <200907181948.54594.chunkeey@web.de> (raw)
In-Reply-To: <200907181808.05142.chunkeey@web.de>

On Saturday 18 July 2009 18:08:04 Christian Lamparter wrote:
> On Saturday 18 July 2009 17:03:18 Larry Finger wrote:
> > Thanks for the patch. I'll let you know what happens.
> I have my doubts. Do you still have the WARN_ON dump?
> or at least which of the two functions are listed in the dump?
> - rate_control_get_rate 
> - rate_control_rate_init <- unlikely/really surprising

found a similar WARNINGs on kerneloops:
http://www.kerneloops.org/raw.php?rawid=449304&msgid= 
but the user has ath5k.

and there's more: iwlagn used to have this issue, but they fixed it.
---
commit c338ba3ca5bef2df2082d9e8d336ff7b2880c326                                                                                        
Author: Abbas, Mohamed <mohamed.abbas@intel.com>                                                                                       
Date:   Wed Jan 21 10:58:02 2009 -0800 

    iwlwifi: fix rs_get_rate WARN_ON()
                                      
    In ieee80211_sta structure there is u64 supp_rates[IEEE80211_NUM_BANDS]
    this is filled with all support rate from assoc_resp.  If we associate 
    with G-band AP only supp_rates of G-band will be set the other band    
    supp_rates will be set to 0. If the user type this command             
    this will cause mac80211 to set to new channel, mac80211               
    does not disassociate in setting new channel, so the active            
    band is now A-band. then in handling the new essid mac80211 will       
    kick in the assoc steps which involve sending disassociation frame.    
    in this mac80211 will WARN_ON sta->supp_rates[A_BAND] == 0.    
---

Larry, can you confirm that the frame which triggers the WARN is a
disassociation frame. 

  reply	other threads:[~2009-07-18 17:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4A611FC0.9040507@lwfinger.net>
     [not found] ` <200907181433.47985.chunkeey@web.de>
2009-07-18 15:03   ` WARN_ON at minstrel_get_rate (include/net/mac80211.h:2111) with p54usb Larry Finger
2009-07-18 16:08     ` WARN_ON at minstrel_get_rate (include/net/mac80211.h:2111) Christian Lamparter
2009-07-18 17:48       ` Christian Lamparter [this message]
2009-07-20 16:17         ` Luis R. Rodriguez
2009-07-18 21:19     ` WARN_ON at minstrel_get_rate (include/net/mac80211.h:2111) with p54usb Bob Copeland
2009-07-18 22:32       ` Christian Lamparter
2009-07-19 14:37         ` Larry Finger
2009-07-19 20:09           ` [PATCH] mac80211: do not monitor the connection while scanning Christian Lamparter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907181948.54594.chunkeey@web.de \
    --to=chunkeey@web.de \
    --cc=Larry.Finger@lwfinger.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).