WARNING: at net/mac80211/tx.c:561

WARNING: at net/mac80211/tx.c:561

[Fabio Rossi]

I'm using the last wireless-testing.git and I have experienced the following 
WARNING:

 WARNING: at net/mac80211/tx.c:561 ieee80211_tx_h_rate_ctrl+0x3d1/0x470 
[mac80211]()
 Hardware name: System Name
 wlan0: Dropped data frame as no usable bitrate found while scanning and 
associated. Target station: 00:0c:f6:xx:xx:xx on 5 GHz band
 Modules linked in: ath5k mac80211 ath cfg80211
 Pid: 1270, comm: phy0 Tainted: G        W  2.6.31-rc3-wl #140
 Call Trace:
  [<e1aaa0a1>] ? ieee80211_tx_h_rate_ctrl+0x3d1/0x470 [mac80211]
  [<e1aaa0a1>] ? ieee80211_tx_h_rate_ctrl+0x3d1/0x470 [mac80211]
  [<c101d37c>] warn_slowpath_common+0x7c/0xa0
  [<e1aaa0a1>] ? ieee80211_tx_h_rate_ctrl+0x3d1/0x470 [mac80211]
  [<c101d3e6>] warn_slowpath_fmt+0x26/0x30
  [<e1aaa0a1>] ieee80211_tx_h_rate_ctrl+0x3d1/0x470 [mac80211]
  [<e1af8afb>] ? ath5k_hw_reset_tx_queue+0x51b/0x830 [ath5k]
  [<e1aa8aa5>] ? ieee80211_tx_prepare+0x105/0x320 [mac80211]
  [<e1aaa489>] invoke_tx_handlers+0x69/0xf0 [mac80211]
  [<e1aaa64f>] ieee80211_tx+0x5f/0x1f0 [mac80211]
  [<c139f940>] ? skb_release_data+0x50/0x90
  [<c139fa83>] ? pskb_expand_head+0x103/0x190
  [<e1aaa8e5>] ieee80211_xmit+0x105/0x270 [mac80211]
  [<e1aaaa9e>] ieee80211_tx_skb+0x4e/0x60 [mac80211]
  [<e1aad7a2>] ieee80211_send_probe_req+0x112/0x180 [mac80211]
  [<c1017168>] ? dequeue_task+0x48/0x90
  [<c101e11b>] ? printk+0x1b/0x20
  [<e1a9ea9a>] ieee80211_mgd_probe_ap+0x11a/0x150 [mac80211]
  [<e1a9eb12>] ieee80211_beacon_loss_work+0x12/0x20 [mac80211]
  [<c102c75c>] worker_thread+0xec/0x1c0
  [<c1454b7d>] ? schedule+0x18d/0x370
  [<e1a9eb00>] ? ieee80211_beacon_loss_work+0x0/0x20 [mac80211]
  [<c102f740>] ? autoremove_wake_function+0x0/0x40
  [<c102c670>] ? worker_thread+0x0/0x1c0
  [<c102f494>] kthread+0x74/0x80
  [<c102f420>] ? kthread+0x0/0x80
  [<c10032d3>] kernel_thread_helper+0x7/0x14
 ---[ end trace a5a80f7488aa4974 ]---

I have a 802.11abg wireless NIC and I'm currently using a 802.11g access 
point.

Fabio

Re: WARNING: at net/mac80211/tx.c:561

[Luis R. Rodriguez]

On Wed, Jul 22, 2009 at 3:51 PM, Fabio Rossi<rossi.f@inwind.it> wrote:
> I'm using the last wireless-testing.git and I have experienced the following
> WARNING:
>
>  WARNING: at net/mac80211/tx.c:561 ieee80211_tx_h_rate_ctrl+0x3d1/0x470
> [mac80211]()

Please try a git pull

  Luis
>  Hardware name: System Name
>  wlan0: Dropped data frame as no usable bitrate found while scanning and
> associated. Target station: 00:0c:f6:xx:xx:xx on 5 GHz band
>  Modules linked in: ath5k mac80211 ath cfg80211
>  Pid: 1270, comm: phy0 Tainted: G        W  2.6.31-rc3-wl #140
>  Call Trace:
>  [<e1aaa0a1>] ? ieee80211_tx_h_rate_ctrl+0x3d1/0x470 [mac80211]
>  [<e1aaa0a1>] ? ieee80211_tx_h_rate_ctrl+0x3d1/0x470 [mac80211]
>  [<c101d37c>] warn_slowpath_common+0x7c/0xa0
>  [<e1aaa0a1>] ? ieee80211_tx_h_rate_ctrl+0x3d1/0x470 [mac80211]
>  [<c101d3e6>] warn_slowpath_fmt+0x26/0x30
>  [<e1aaa0a1>] ieee80211_tx_h_rate_ctrl+0x3d1/0x470 [mac80211]
>  [<e1af8afb>] ? ath5k_hw_reset_tx_queue+0x51b/0x830 [ath5k]
>  [<e1aa8aa5>] ? ieee80211_tx_prepare+0x105/0x320 [mac80211]
>  [<e1aaa489>] invoke_tx_handlers+0x69/0xf0 [mac80211]
>  [<e1aaa64f>] ieee80211_tx+0x5f/0x1f0 [mac80211]
>  [<c139f940>] ? skb_release_data+0x50/0x90
>  [<c139fa83>] ? pskb_expand_head+0x103/0x190
>  [<e1aaa8e5>] ieee80211_xmit+0x105/0x270 [mac80211]
>  [<e1aaaa9e>] ieee80211_tx_skb+0x4e/0x60 [mac80211]
>  [<e1aad7a2>] ieee80211_send_probe_req+0x112/0x180 [mac80211]
>  [<c1017168>] ? dequeue_task+0x48/0x90
>  [<c101e11b>] ? printk+0x1b/0x20
>  [<e1a9ea9a>] ieee80211_mgd_probe_ap+0x11a/0x150 [mac80211]
>  [<e1a9eb12>] ieee80211_beacon_loss_work+0x12/0x20 [mac80211]
>  [<c102c75c>] worker_thread+0xec/0x1c0
>  [<c1454b7d>] ? schedule+0x18d/0x370
>  [<e1a9eb00>] ? ieee80211_beacon_loss_work+0x0/0x20 [mac80211]
>  [<c102f740>] ? autoremove_wake_function+0x0/0x40
>  [<c102c670>] ? worker_thread+0x0/0x1c0
>  [<c102f494>] kthread+0x74/0x80
>  [<c102f420>] ? kthread+0x0/0x80
>  [<c10032d3>] kernel_thread_helper+0x7/0x14
>  ---[ end trace a5a80f7488aa4974 ]---
>
> I have a 802.11abg wireless NIC and I'm currently using a 802.11g access
> point.
>
> Fabio
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: WARNING: at net/mac80211/tx.c:561

[Fabio Rossi]

On Thursday 23 July 2009, Luis R. Rodriguez wrote:

> On Wed, Jul 22, 2009 at 3:51 PM, Fabio Rossi<rossi.f@inwind.it> wrote:
> > I'm using the last wireless-testing.git and I have experienced the
> > following WARNING:
> >
> >  WARNING: at net/mac80211/tx.c:561 ieee80211_tx_h_rate_ctrl+0x3d1/0x470
> > [mac80211]()
>
> Please try a git pull

I was already working with the latest release:
  v2.6.31-rc3-28452-g5bfcdb0
so I confirm that I get the warning quite often (every 15 seconds).


Fabio

Re: WARNING: at net/mac80211/tx.c:561

[Luis R. Rodriguez]

On Thu, Jul 23, 2009 at 10:07 AM, Fabio Rossi<rossi.f@inwind.it> wrote:
> On Thursday 23 July 2009, Luis R. Rodriguez wrote:
>
>> On Wed, Jul 22, 2009 at 3:51 PM, Fabio Rossi<rossi.f@inwind.it> wrote:
>> > I'm using the last wireless-testing.git and I have experienced the
>> > following WARNING:
>> >
>> >  WARNING: at net/mac80211/tx.c:561 ieee80211_tx_h_rate_ctrl+0x3d1/0x470
>> > [mac80211]()
>>
>> Please try a git pull
>
> I was already working with the latest release:
>  v2.6.31-rc3-28452-g5bfcdb0
> so I confirm that I get the warning quite often (every 15 seconds).

What channel is your AP on?
Is your AP 00:0c:f6:xx:xx:xx ?

  Luis

Re: WARNING: at net/mac80211/tx.c:561

[Fabio Rossi]

On Thursday 23 July 2009, Luis R. Rodriguez wrote:

> On Thu, Jul 23, 2009 at 10:07 AM, Fabio Rossi<rossi.f@inwind.it> wrote:
> > On Thursday 23 July 2009, Luis R. Rodriguez wrote:
> >> On Wed, Jul 22, 2009 at 3:51 PM, Fabio Rossi<rossi.f@inwind.it> wrote:
> >> > I'm using the last wireless-testing.git and I have experienced the
> >> > following WARNING:
> >> >
> >> >  WARNING: at net/mac80211/tx.c:561
> >> > ieee80211_tx_h_rate_ctrl+0x3d1/0x470 [mac80211]()
> >>
> >> Please try a git pull
> >
> > I was already working with the latest release:
> >  v2.6.31-rc3-28452-g5bfcdb0
> > so I confirm that I get the warning quite often (every 15 seconds).
>
> What channel is your AP on?
> Is your AP 00:0c:f6:xx:xx:xx ?

Yes, that is my AP configured on channel 8 (Frequency 2.447 GHz):

          Cell 05 - Address: 00:0C:F6:xx:xx:xx
                    Channel:8
                    Frequency:2.447 GHz (Channel 8)
                    Quality=48/70  Signal level=-62 dBm
                    Encryption key:on
                    ESSID:""
                    Bit Rates:1 Mb/s; 2 Mb/s; 5.5 Mb/s; 11 Mb/s
                    Bit Rates:6 Mb/s; 9 Mb/s; 12 Mb/s; 18 Mb/s; 24 Mb/s
                              36 Mb/s; 48 Mb/s; 54 Mb/s
                    Mode:Master
                    Extra:tsf=000000007803aa0c
                    Extra: Last beacon: 4352ms ago
                    IE: Unknown: 0000
                    IE: Unknown: 010482848B96
                    IE: Unknown: 030108
                    IE: Unknown: 050400010000
                    IE: Unknown: 2A0104
                    IE: Unknown: 32080C1218243048606C
                    IE: Unknown: DD07000C4301000000


Fabio

Re: WARNING: at net/mac80211/tx.c:561

[Luis R. Rodriguez]

On Thu, Jul 23, 2009 at 07:28:44PM +0200, Fabio Rossi wrote:
> On Thursday 23 July 2009, Luis R. Rodriguez wrote:
> 
> > On Thu, Jul 23, 2009 at 10:07 AM, Fabio Rossi<rossi.f@inwind.it> wrote:
> > > On Thursday 23 July 2009, Luis R. Rodriguez wrote:
> > >> On Wed, Jul 22, 2009 at 3:51 PM, Fabio Rossi<rossi.f@inwind.it> wrote:
> > >> > I'm using the last wireless-testing.git and I have experienced the
> > >> > following WARNING:
> > >> >
> > >> >  WARNING: at net/mac80211/tx.c:561
> > >> > ieee80211_tx_h_rate_ctrl+0x3d1/0x470 [mac80211]()
> > >>
> > >> Please try a git pull
> > >
> > > I was already working with the latest release:
> > >  v2.6.31-rc3-28452-g5bfcdb0
> > > so I confirm that I get the warning quite often (every 15 seconds).
> >
> > What channel is your AP on?
> > Is your AP 00:0c:f6:xx:xx:xx ?
> 
> Yes, that is my AP configured on channel 8 (Frequency 2.447 GHz):
> 
>           Cell 05 - Address: 00:0C:F6:xx:xx:xx
>                     Channel:8
>                     Frequency:2.447 GHz (Channel 8)
>                     Quality=48/70  Signal level=-62 dBm
>                     Encryption key:on
>                     ESSID:""
>                     Bit Rates:1 Mb/s; 2 Mb/s; 5.5 Mb/s; 11 Mb/s
>                     Bit Rates:6 Mb/s; 9 Mb/s; 12 Mb/s; 18 Mb/s; 24 Mb/s
>                               36 Mb/s; 48 Mb/s; 54 Mb/s
>                     Mode:Master
>                     Extra:tsf=000000007803aa0c
>                     Extra: Last beacon: 4352ms ago
>                     IE: Unknown: 0000
>                     IE: Unknown: 010482848B96
>                     IE: Unknown: 030108
>                     IE: Unknown: 050400010000
>                     IE: Unknown: 2A0104
>                     IE: Unknown: 32080C1218243048606C
>                     IE: Unknown: DD07000C4301000000

It is as I suspected, a real WARNING for a bug in mac80211, we should
not be sending frames on 5 GHz onyour 2.4 GHz AP.

Please try this patch:

From: Luis R. Rodriguez <lrodriguez@atheros.com>
Subject: [PATCH] mac80211: do not trigger beacon work if scanning

We were issues probe requests to the associated AP on the wrong
band. This leads to finding not bitrate. We should not be doing
this, so prevent the timer from stuffing beacon loss work on
the mac80211 workqueue.

Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
 net/mac80211/mlme.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index 523c0d9..e90992e 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -2187,7 +2187,7 @@ static void ieee80211_sta_bcn_mon_timer(unsigned long data)
 		(struct ieee80211_sub_if_data *) data;
 	struct ieee80211_local *local = sdata->local;
 
-	if (local->quiescing)
+	if (local->quiescing || local->sw_scanning || local->hw_scanning)
 		return;
 
 	queue_work(sdata->local->hw.workqueue,
-- 
1.6.3.3

Re: WARNING: at net/mac80211/tx.c:561

[Luis R. Rodriguez]

On Thu, Jul 23, 2009 at 11:17 AM, Luis R.
Rodriguez<mcgrof@bombadil.infradead.org> wrote:
> On Thu, Jul 23, 2009 at 07:28:44PM +0200, Fabio Rossi wrote:
>> On Thursday 23 July 2009, Luis R. Rodriguez wrote:
>>
>> > On Thu, Jul 23, 2009 at 10:07 AM, Fabio Rossi<rossi.f@inwind.it> wrote:
>> > > On Thursday 23 July 2009, Luis R. Rodriguez wrote:
>> > >> On Wed, Jul 22, 2009 at 3:51 PM, Fabio Rossi<rossi.f@inwind.it> wrote:
>> > >> > I'm using the last wireless-testing.git and I have experienced the
>> > >> > following WARNING:
>> > >> >
>> > >> >  WARNING: at net/mac80211/tx.c:561
>> > >> > ieee80211_tx_h_rate_ctrl+0x3d1/0x470 [mac80211]()
>> > >>
>> > >> Please try a git pull
>> > >
>> > > I was already working with the latest release:
>> > >  v2.6.31-rc3-28452-g5bfcdb0
>> > > so I confirm that I get the warning quite often (every 15 seconds).
>> >
>> > What channel is your AP on?
>> > Is your AP 00:0c:f6:xx:xx:xx ?
>>
>> Yes, that is my AP configured on channel 8 (Frequency 2.447 GHz):
>>
>>           Cell 05 - Address: 00:0C:F6:xx:xx:xx
>>                     Channel:8
>>                     Frequency:2.447 GHz (Channel 8)
>>                     Quality=48/70  Signal level=-62 dBm
>>                     Encryption key:on
>>                     ESSID:""
>>                     Bit Rates:1 Mb/s; 2 Mb/s; 5.5 Mb/s; 11 Mb/s
>>                     Bit Rates:6 Mb/s; 9 Mb/s; 12 Mb/s; 18 Mb/s; 24 Mb/s
>>                               36 Mb/s; 48 Mb/s; 54 Mb/s
>>                     Mode:Master
>>                     Extra:tsf=000000007803aa0c
>>                     Extra: Last beacon: 4352ms ago
>>                     IE: Unknown: 0000
>>                     IE: Unknown: 010482848B96
>>                     IE: Unknown: 030108
>>                     IE: Unknown: 050400010000
>>                     IE: Unknown: 2A0104
>>                     IE: Unknown: 32080C1218243048606C
>>                     IE: Unknown: DD07000C4301000000
>
> It is as I suspected, a real WARNING for a bug in mac80211, we should
> not be sending frames on 5 GHz onyour 2.4 GHz AP.
>
> Please try this patch:
>
> From: Luis R. Rodriguez <lrodriguez@atheros.com>
> Subject: [PATCH] mac80211: do not trigger beacon work if scanning
>
> We were issues probe requests to the associated AP on the wrong
> band. This leads to finding not bitrate. We should not be doing
> this, so prevent the timer from stuffing beacon loss work on
> the mac80211 workqueue.
>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
>  net/mac80211/mlme.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> index 523c0d9..e90992e 100644
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -2187,7 +2187,7 @@ static void ieee80211_sta_bcn_mon_timer(unsigned long data)
>                (struct ieee80211_sub_if_data *) data;
>        struct ieee80211_local *local = sdata->local;
>
> -       if (local->quiescing)
> +       if (local->quiescing || local->sw_scanning || local->hw_scanning)
>                return;

Heh no wait, this is very wrong.

  Luis

Re: WARNING: at net/mac80211/tx.c:561

[Luis R. Rodriguez]

On Thu, Jul 23, 2009 at 11:19 AM, Luis R. Rodriguez<mcgrof@gmail.com> wrote:
> On Thu, Jul 23, 2009 at 11:17 AM, Luis R.
> Rodriguez<mcgrof@bombadil.infradead.org> wrote:
>> On Thu, Jul 23, 2009 at 07:28:44PM +0200, Fabio Rossi wrote:
>>> On Thursday 23 July 2009, Luis R. Rodriguez wrote:
>>>
>>> > On Thu, Jul 23, 2009 at 10:07 AM, Fabio Rossi<rossi.f@inwind.it> wrote:
>>> > > On Thursday 23 July 2009, Luis R. Rodriguez wrote:
>>> > >> On Wed, Jul 22, 2009 at 3:51 PM, Fabio Rossi<rossi.f@inwind.it> wrote:
>>> > >> > I'm using the last wireless-testing.git and I have experienced the
>>> > >> > following WARNING:
>>> > >> >
>>> > >> >  WARNING: at net/mac80211/tx.c:561
>>> > >> > ieee80211_tx_h_rate_ctrl+0x3d1/0x470 [mac80211]()
>>> > >>
>>> > >> Please try a git pull
>>> > >
>>> > > I was already working with the latest release:
>>> > >  v2.6.31-rc3-28452-g5bfcdb0
>>> > > so I confirm that I get the warning quite often (every 15 seconds).
>>> >
>>> > What channel is your AP on?
>>> > Is your AP 00:0c:f6:xx:xx:xx ?
>>>
>>> Yes, that is my AP configured on channel 8 (Frequency 2.447 GHz):
>>>
>>>           Cell 05 - Address: 00:0C:F6:xx:xx:xx
>>>                     Channel:8
>>>                     Frequency:2.447 GHz (Channel 8)
>>>                     Quality=48/70  Signal level=-62 dBm
>>>                     Encryption key:on
>>>                     ESSID:""
>>>                     Bit Rates:1 Mb/s; 2 Mb/s; 5.5 Mb/s; 11 Mb/s
>>>                     Bit Rates:6 Mb/s; 9 Mb/s; 12 Mb/s; 18 Mb/s; 24 Mb/s
>>>                               36 Mb/s; 48 Mb/s; 54 Mb/s
>>>                     Mode:Master
>>>                     Extra:tsf=000000007803aa0c
>>>                     Extra: Last beacon: 4352ms ago
>>>                     IE: Unknown: 0000
>>>                     IE: Unknown: 010482848B96
>>>                     IE: Unknown: 030108
>>>                     IE: Unknown: 050400010000
>>>                     IE: Unknown: 2A0104
>>>                     IE: Unknown: 32080C1218243048606C
>>>                     IE: Unknown: DD07000C4301000000
>>
>> It is as I suspected, a real WARNING for a bug in mac80211, we should
>> not be sending frames on 5 GHz onyour 2.4 GHz AP.
>>
>> Please try this patch:
>>
>> From: Luis R. Rodriguez <lrodriguez@atheros.com>
>> Subject: [PATCH] mac80211: do not trigger beacon work if scanning
>>
>> We were issues probe requests to the associated AP on the wrong
>> band. This leads to finding not bitrate. We should not be doing
>> this, so prevent the timer from stuffing beacon loss work on
>> the mac80211 workqueue.
>>
>> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
>> ---
>>  net/mac80211/mlme.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
>> index 523c0d9..e90992e 100644
>> --- a/net/mac80211/mlme.c
>> +++ b/net/mac80211/mlme.c
>> @@ -2187,7 +2187,7 @@ static void ieee80211_sta_bcn_mon_timer(unsigned long data)
>>                (struct ieee80211_sub_if_data *) data;
>>        struct ieee80211_local *local = sdata->local;
>>
>> -       if (local->quiescing)
>> +       if (local->quiescing || local->sw_scanning || local->hw_scanning)
>>                return;
>
> Heh no wait, this is very wrong.

Never mind, please do try it. If we are scanning we should not be
sending probe requests through a timer. That clarifies what I mean and
I should add that to the commit log. But please do try it.

  Luis

Re: WARNING: at net/mac80211/tx.c:561

[Fabio Rossi]

On Thursday 23 July 2009, Luis R. Rodriguez wrote:

> >> Please try this patch:
> >>
> >> From: Luis R. Rodriguez <lrodriguez@atheros.com>
> >> Subject: [PATCH] mac80211: do not trigger beacon work if scanning
> >>
> >> We were issues probe requests to the associated AP on the wrong
> >> band. This leads to finding not bitrate. We should not be doing
> >> this, so prevent the timer from stuffing beacon loss work on
> >> the mac80211 workqueue.
> >>
> >> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> >> ---
> >>  net/mac80211/mlme.c |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> >> index 523c0d9..e90992e 100644
> >> --- a/net/mac80211/mlme.c
> >> +++ b/net/mac80211/mlme.c
> >> @@ -2187,7 +2187,7 @@ static void ieee80211_sta_bcn_mon_timer(unsigned
> >> long data) (struct ieee80211_sub_if_data *) data;
> >>        struct ieee80211_local *local = sdata->local;
> >>
> >> -       if (local->quiescing)
> >> +       if (local->quiescing || local->sw_scanning ||
> >> local->hw_scanning) return;
> >
> > Heh no wait, this is very wrong.
>
> Never mind, please do try it. If we are scanning we should not be
> sending probe requests through a timer. That clarifies what I mean and
> I should add that to the commit log. But please do try it.

Patch applied, now the warning is disappeared!

Fabio