From: Holger Schurig <hs4233@mail.mn-solutions.de>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: dcbw@redhat.com, libertas-dev@lists.infradead.org,
linux-wireless@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] libertas: Read buffer overflow
Date: Tue, 28 Jul 2009 10:19:56 +0200 [thread overview]
Message-ID: <200907281019.56855.hs4233@mail.mn-solutions.de> (raw)
In-Reply-To: <4A6EB00D.5010401@gmail.com>
> - size_t num_card_rates = sizeof(lbs_bg_rates);
> + size_t num_card_rates = ARRAY_SIZE(lbs_bg_rates);
Hmm, not sure about this. First I don't know if we need a
variable for this at all. Can't you simply use ARRAY_SIZE()
whenever it's needed?
If you want to keep num_card_rates, you should change it's
type. "size_t" is normally used to denote sizes in bytes, e.g.
it's the type for the length of malloc and friends. But now the
variable holds a number of elements and should be int or
unsigned int.
--
http://www.holgerschurig.de
next prev parent reply other threads:[~2009-07-28 8:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-28 8:00 [PATCH] libertas: Read buffer overflow Roel Kluin
2009-07-28 8:19 ` Holger Schurig [this message]
2009-07-28 10:05 ` Roel Kluin
-- strict thread matches above, loose matches on Subject: below --
2009-08-02 7:44 Roel Kluin
2009-08-04 15:16 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907281019.56855.hs4233@mail.mn-solutions.de \
--to=hs4233@mail.mn-solutions.de \
--cc=akpm@linux-foundation.org \
--cc=dcbw@redhat.com \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).