From: Ivo van Doorn <ivdoorn@gmail.com>
To: Ken Lewis <kennylewis@gmail.com>
Cc: linux-wireless@vger.kernel.org, linux-next@vger.kernel.org,
linux-net@vger.kernel.org
Subject: Re: [RT2X00] Linux-next tree next-20090725 and 20090727 FTBFS
Date: Tue, 28 Jul 2009 18:55:47 +0200 [thread overview]
Message-ID: <200907281855.47790.IvDoorn@gmail.com> (raw)
In-Reply-To: <5a44caba0907280935h59a22367la38382a0c9d388bf@mail.gmail.com>
Hi,
> Kernel: arch/x86/boot/bzImage is ready (#1)
> Building modules, stage 2.
> MODPOST 12 modules
> ERROR: "rt2x00mac_set_tim" [drivers/net/wireless/rt2x00/rt2500pci.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
>
> rt2x00mac_set_tim is used in rt2500pci.c and declared in rt2x00mac.c
> within a section #IFDEF'd for CONFIG_RT2X00_LIB_CRYPTO. I can get the
> kernel modules to build -- the error reports a missing symbol due to
> the definition of rt2x00mac_set_tim being IFDEFfed out, and excluding
> rt2x00mac_set_tim builds the module successfully -- but can't confirm
> whether it works due to a quirk of KDE, NetworkManager and my Linksys
> router not cooperating.
>
> In terms of the right fix: should rt2500pci depend (in KConfig) on
> CONFIG_RT2X00_LIB_CRYPTO, or should rt2x00mac_set_tim be outside the
> IFDEF?
well rt2x00mac_set_tim has nothing to do with CRYPTO so the function
should simply be moved. I'll send a patch to fix this in a few minutes.
Ivo
prev parent reply other threads:[~2009-07-28 16:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-28 16:35 [RT2X00] Linux-next tree next-20090725 and 20090727 FTBFS Ken Lewis
2009-07-28 16:55 ` Ivo van Doorn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907281855.47790.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=kennylewis@gmail.com \
--cc=linux-net@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).