Re: [PATCH] rt2x00dev: cancel all work on disconnect

[Michael Buesch <mb@bu3sch.de>]

On Thursday 30 July 2009 20:45:15 Ivo van Doorn wrote:
> Hi,
> 
> I assume fixes the bug Michael reported on Linux-wireless yesterday?

I didn't test that, yet, but the patch looks sane anyway.

> The patch looks good, but I have some minor modification request:
> 
> On Wednesday 29 July 2009, Pavel Roskin wrote:
> > Signed-off-by: Pavel Roskin <proski@gnu.org>
> > ---
> >  drivers/net/wireless/rt2x00/rt2x00dev.c |    7 +++++++
> >  1 files changed, 7 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
> > index 658a63b..66b303b 100644
> > --- a/drivers/net/wireless/rt2x00/rt2x00dev.c
> > +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
> > @@ -888,6 +888,13 @@ void rt2x00lib_remove_dev(struct rt2x00_dev *rt2x00dev)
> >  	clear_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags);
> >  
> >  	/*
> > +	 * Cancel all work.
> > +	 */
> > +	rt2x00link_stop_tuner(rt2x00dev);
> 
> This one isn't needed. rt2x00lib_disable_radio() is doing this.
> 
> > +	cancel_work_sync(&rt2x00dev->filter_work);
> > +	cancel_work_sync(&rt2x00dev->intf_work);
> 
> Could you move these 2 until after the call to rt2x00lib_disable_radio()?
> 
> > +	/*
> >  	 * Disable radio.
> >  	 */
> >  	rt2x00lib_disable_radio(rt2x00dev);
> 
> Thanks,
> 
> Ivo
> 
> 



-- 
Greetings, Michael.