From: Lennert Buytenhek <buytenh@wantstofly.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org, nico@cam.org
Subject: Re: [PATCH 4/5] mwl8k: prevent crash in ->configure_filter() if no interface was added
Date: Tue, 4 Aug 2009 01:46:51 +0200 [thread overview]
Message-ID: <20090803234651.GN18639@mail.wantstofly.org> (raw)
In-Reply-To: <1249329790.4561.3.camel@johannes.local>
On Mon, Aug 03, 2009 at 10:03:10PM +0200, Johannes Berg wrote:
> > if (changed_flags & FIF_BCN_PRBRESP_PROMISC) {
> > if (*total_flags & FIF_BCN_PRBRESP_PROMISC)
> > rc = mwl8k_cmd_set_pre_scan(hw);
> > else {
> > - mv_vif = MWL8K_VIF(priv->vif);
> > - rc = mwl8k_cmd_set_post_scan(hw, mv_vif->bssid);
>
> Btw, there are pre- and post-scan hooks now.
These hardware commands are slightly misnamed -- they are called
PRE_SCAN/POST_SCAN, but what they do is program the receive filter.
It seems appropriate to keep that in ->configure_filter() ?
next prev parent reply other threads:[~2009-08-03 23:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-03 19:58 [PATCH 4/5] mwl8k: prevent crash in ->configure_filter() if no interface was added Lennert Buytenhek
2009-08-03 20:03 ` Johannes Berg
2009-08-03 23:46 ` Lennert Buytenhek [this message]
2009-08-04 6:37 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090803234651.GN18639@mail.wantstofly.org \
--to=buytenh@wantstofly.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox