* [PATCH] p54: disable PS by default
@ 2009-08-14 11:23 Christian Lamparter
2009-08-15 19:59 ` Larry Finger
0 siblings, 1 reply; 2+ messages in thread
From: Christian Lamparter @ 2009-08-14 11:23 UTC (permalink / raw)
To: wireless; +Cc: John W. Linville, Larry Finger, Johannes Berg
Johannes kindly pointed out that I completely missed a hunk in
his patch: "[PATCH] cfg80211: allow driver to override PS default".
The driver must explicitly set ps_default to false,
as the setting is pre-filled with the kconfig default.
Signed-off-by: Christian Lamparter <chunkeey@web.de>
---
diff --git a/drivers/net/wireless/p54/main.c b/drivers/net/wireless/p54/main.c
index 4a741df..77203e3 100644
--- a/drivers/net/wireless/p54/main.c
+++ b/drivers/net/wireless/p54/main.c
@@ -575,6 +575,12 @@ struct ieee80211_hw *p54_init_common(size_t priv_data_len)
dev->extra_tx_headroom = sizeof(struct p54_hdr) + 4 +
sizeof(struct p54_tx_data);
+ /*
+ * For now, disable PS by default because it affects
+ * link stability significantly.
+ */
+ dev->wiphy->ps_default = false;
+
mutex_init(&priv->conf_mutex);
mutex_init(&priv->eeprom_mutex);
init_completion(&priv->eeprom_comp);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] p54: disable PS by default
2009-08-14 11:23 [PATCH] p54: disable PS by default Christian Lamparter
@ 2009-08-15 19:59 ` Larry Finger
0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2009-08-15 19:59 UTC (permalink / raw)
To: Christian Lamparter; +Cc: wireless, John W. Linville, Johannes Berg
Christian Lamparter wrote:
> Johannes kindly pointed out that I completely missed a hunk in
> his patch: "[PATCH] cfg80211: allow driver to override PS default".
>
> The driver must explicitly set ps_default to false,
> as the setting is pre-filled with the kconfig default.
>
> Signed-off-by: Christian Lamparter <chunkeey@web.de>
> ---
With this patch, I no longer see the disconnects. ACK.
Larry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-15 20:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-14 11:23 [PATCH] p54: disable PS by default Christian Lamparter
2009-08-15 19:59 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).