From: Michael Buesch <mb@bu3sch.de>
To: Pavel Roskin <proski@gnu.org>
Cc: "Gábor Stefanik" <netrolller.3d@gmail.com>,
linux-wireless@vger.kernel.org, bcm43xx-dev@lists.berlios.de,
"Larry Finger" <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] b43: Fix sparse warnings
Date: Sat, 15 Aug 2009 12:04:10 +0200 [thread overview]
Message-ID: <200908151204.11024.mb@bu3sch.de> (raw)
In-Reply-To: <1250285729.8137.48.camel@mj>
On Friday 14 August 2009 23:35:29 Pavel Roskin wrote:
> On Fri, 2009-08-14 at 23:04 +0200, Gábor Stefanik wrote:
> > On Fri, Aug 14, 2009 at 11:00 PM, Michael Buesch<mb@bu3sch.de> wrote:
> > > On Friday 14 August 2009 22:52:13 Pavel Roskin wrote:
> > >> On Fri, 2009-08-14 at 22:15 +0200, Michael Buesch wrote:
> > >>
> > >> > > - b43_phy_mask(dev, 0x048A, (u16)~0x8000);
> > >> > > + b43_phy_mask(dev, 0x048A, (u16)(~0x8000 & 0xFFFF));
> > >> >
> > >
> > >> I would just use 0x7fff here.
> > >
> > > That does not work if 0x8000 is a #defined bit.
> >
> > What about ~((u16)0x8000)?
>
> phy_g.c:974: warning: large integer implicitly truncated to unsigned
> type
>
> > (Or maybe ~(u16)0x8000 is enough, without
> > the extra parentheses.)
>
> Same thing. Sparse complains whether the cast is explicit or implicit.
>
I still do not understand why it does complain about an _explicit_ truncation.
That's simply stupid. If I program an explicit truncation I _do_ mean to truncate the value.
--
Greetings, Michael.
next prev parent reply other threads:[~2009-08-15 10:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-13 22:15 [PATCH] b43: Fix sparse warnings Larry Finger
2009-08-14 20:15 ` Michael Buesch
2009-08-14 20:52 ` Pavel Roskin
2009-08-14 21:00 ` Michael Buesch
2009-08-14 21:04 ` Gábor Stefanik
2009-08-14 21:35 ` Pavel Roskin
2009-08-15 10:04 ` Michael Buesch [this message]
2009-08-17 20:30 ` Pavel Roskin
2009-08-18 13:12 ` Michael Buesch
2009-08-14 21:29 ` Pavel Roskin
2009-08-14 21:46 ` Pavel Roskin
2009-08-15 10:08 ` Michael Buesch
2009-08-14 21:33 ` Larry Finger
-- strict thread matches above, loose matches on Subject: below --
2007-09-19 16:30 Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908151204.11024.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Larry.Finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=netrolller.3d@gmail.com \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).