linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Zhu Yi <yi.zhu@intel.com>
Cc: "Gábor Stefanik" <netrolller.3d@gmail.com>,
	"Julia Lawall" <julia@diku.dk>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: question about ieee80211_tx.c (fwd)
Date: Mon, 17 Aug 2009 18:35:02 -0700	[thread overview]
Message-ID: <20090818013502.GD20566@suse.de> (raw)
In-Reply-To: <1250558021.9651.35.camel@debian>

On Tue, Aug 18, 2009 at 09:13:41AM +0800, Zhu Yi wrote:
> On Mon, 2009-08-17 at 19:50 +0800, Gábor Stefanik wrote:
> > On Mon, Aug 17, 2009 at 10:03 AM, Julia Lawall<julia@diku.dk> wrote:
> > > The files ieee80211_tx.c in the directories
> > > drivers/staging/rtl8192su/ieee80211 and
> > drivers/staging/rtl8192e/ieee80211
> > > both contain the following code in the function
> > > ieee80211_query_protectionmode:
> > >
> > >       if (ieee->mode == IW_MODE_MASTER)
> > >                        goto NO_PROTECTION;
> > >
> > > Elsewhere in these files when there is a comparison against an
> > IW_MODE
> > > value, the field that is compared is iw_mode.  Should that be the
> > case
> > > here as well?
> > >
> > > thanks,
> > > julia
> > 
> > I don't know; rtl8192su & rtl8192e use a modified version of the
> > libipw stack, rather than the mac80211 stack found behind non-staging
> > drivers.
> 
> This is clearly a bug. The question is: who is maintaining this driver
> and why it doesn't use/extend ieee80211/libipw?

I maintain it, and I am working to convert it to use the existing
ieee80211 stack that is in the kernel.  Remember, these are drivers in
the staging tree, they are usually "crap" :)

thanks,

greg k-h

  reply	other threads:[~2009-08-18  1:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-17  8:03 question about ieee80211_tx.c (fwd) Julia Lawall
2009-08-17 11:50 ` Gábor Stefanik
2009-08-18  1:13   ` Zhu Yi
2009-08-18  1:35     ` Greg KH [this message]
2009-08-19 16:32       ` Dan Williams
2009-08-19 16:33         ` Greg KH
2009-08-19 16:39           ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090818013502.GD20566@suse.de \
    --to=gregkh@suse.de \
    --cc=julia@diku.dk \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netrolller.3d@gmail.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).