Re: [PATCH 10/29] mwl8k: fix mwl8k_configure_filter() parameter lifetime issue

[Lennert Buytenhek <buytenh@wantstofly.org>]

On Tue, Aug 18, 2009 at 05:52:33AM +0200, Lennert Buytenhek wrote:

> mwl8k_configure_filter() passes pointers to total_flags and the
> multicast address list to a workqueue function, while there is no
> guarantee that those pointers will still be valid by the time the
> workqueue function runs.
> 
> Solve this by passing total_flags by value, and by passing an
> already built multicast address setup command packet to the workqueue
> function so that we don't have to look at the multicast address list
> itself outside of mwl8k_configure_filter().
> 
> Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>

This will clash with:

	http://article.gmane.org/gmane.linux.kernel.wireless.general/38141

But that is easy to fix up.  (The easiest would probably be to not
apply the mwl8k part of that patch, and I'll send a followup patch
to implement ->prepare_multicast() for mwl8k.)