From: Lennert Buytenhek <buytenh@wantstofly.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] mac80211: fix configure_filter invocation after stop
Date: Thu, 20 Aug 2009 21:56:11 +0200 [thread overview]
Message-ID: <20090820195611.GH6171@mail.wantstofly.org> (raw)
In-Reply-To: <1250791340.9307.6.camel@johannes.local>
On Thu, Aug 20, 2009 at 08:02:20PM +0200, Johannes Berg wrote:
> Since configure_filter can sleep now, any multicast
> configuration needed to be postponed to a work struct.
> This, however, lead to a problem that we could queue
> the work, stop the device and then afterwards invoke
> configure_filter which may lead to driver hangs and is
> a bug. To fix this, we can just cancel the filter work
> since it's unnecessary to do after stopping the hw.
>
> Since there are various places that call drv_stop, and
> two of them do very similar things, the code for them
> can be put into a shared function at the same time.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> Reported-by: Lennert Buytenhek <buytenh@wantstofly.org>
Seems to work for me, I now no longer see firmware commands being
posted after ->stop() is called.
Tested-by: Lennert Buytenhek <buytenh@marvell.com>
prev parent reply other threads:[~2009-08-20 19:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 17:46 [PATCH] mac80211: fix configure_filter invocation after stop Johannes Berg
2009-08-20 18:02 ` [PATCH v2] " Johannes Berg
2009-08-20 19:56 ` Lennert Buytenhek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090820195611.GH6171@mail.wantstofly.org \
--to=buytenh@wantstofly.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox