From: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
To: "Hin-Tak Leung" <hintak.leung@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
htl10@users.sourceforge.net,
Larry Finger <Larry.Finger@lwfinger.net>,
linux-wireless@vger.kernel.org,
"Luis R. Rodriguez" <mcgrof@gmail.com>
Subject: Re: [RFC/RFT] rtl8187: Implement rfkill support
Date: Wed, 26 Aug 2009 13:57:09 -0300 [thread overview]
Message-ID: <200908261357.09425.herton@mandriva.com.br> (raw)
In-Reply-To: <3ace41890908260807t736848d8x57dff6cf3ac581c6@mail.gmail.com>
Em Qua 26 Ago 2009, às 12:07:52, Hin-Tak Leung escreveu:
> On Wed, Aug 26, 2009 at 3:34 PM, Johannes Berg<johannes@sipsolutions.net> wrote:
> > On Wed, 2009-08-26 at 13:33 +0000, Hin-Tak Leung wrote:
> >
> >> > Or wait ... are you using compat-wireless?
> >>
> >> Yes, I am. I mentioned this and did wonder if the _backport/ part
> >> in /sys/class is important.
> >
> > Sorry, didn't see.
> >
> > Anyway, that's pretty clearly the reason -- Luis added NETDEV_PRE_UP to
> > some compat*.h but obviously the kernel won't ever call that notifier,
> > so cfg80211 doesn't get a chance to reject the IFUP. No idea how to
> > handle that -- it'll be working fine in a regular tree.
> >
> > Luis, the only way to handle that would be to manually call the PRE_UP
> > notifier from mac80211's subif_open() and if that returns an error
> > (warning: the calling convention is weird) return the error... that's
> > weird but would work.
>
> Okay, that explains it. So I can have a Tested-by: ... I just grep for
Ok, I submitted now the patches.
> NETDEV_PRE_UP in compat-wireless and it is only in
> include/net/compat-2.6.31.h (not in 2.6.30) and I am on 2.6.30.5-X . I
> can grab the rawhide 2.6.31 rpms and try it quickly;
> and possibly look at some ugly quick hack backport that? Stay tuned.
>
> Thanks for the help.
>
> Hin-Tak
>
--
[]'s
Herton
next prev parent reply other threads:[~2009-08-26 16:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-22 3:38 [RFC/RFT] rtl8187: Implement rfkill support Herton Ronaldo Krzesinski
2009-08-22 17:12 ` Larry Finger
2009-08-22 21:59 ` Hin-Tak Leung
2009-08-23 19:38 ` Hin-Tak Leung
2009-08-24 18:10 ` Herton Ronaldo Krzesinski
2009-08-24 21:03 ` Hin-Tak Leung
2009-08-24 1:46 ` Larry Finger
2009-08-24 18:03 ` Herton Ronaldo Krzesinski
2009-08-25 1:29 ` Larry Finger
2009-08-25 2:51 ` Hin-Tak Leung
2009-08-25 3:36 ` Larry Finger
2009-08-25 6:51 ` Hin-Tak Leung
2009-08-25 9:27 ` Johannes Berg
2009-08-26 2:43 ` Hin-Tak Leung
2009-08-26 8:57 ` Johannes Berg
2009-08-26 12:45 ` Larry Finger
2009-08-26 13:33 ` Hin-Tak Leung
2009-08-26 14:34 ` Johannes Berg
2009-08-26 15:07 ` Hin-Tak Leung
2009-08-26 16:57 ` Herton Ronaldo Krzesinski [this message]
2009-08-26 16:29 ` Hin-Tak Leung
2009-08-26 20:33 ` Luis R. Rodriguez
2009-08-26 22:06 ` Luis R. Rodriguez
2009-08-26 22:12 ` Johannes Berg
2009-08-26 22:26 ` Luis R. Rodriguez
2009-08-26 22:30 ` Johannes Berg
2009-08-26 22:46 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908261357.09425.herton@mandriva.com.br \
--to=herton@mandriva.com.br \
--cc=Larry.Finger@lwfinger.net \
--cc=hintak.leung@gmail.com \
--cc=htl10@users.sourceforge.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).