From: Holger Schurig <hs4233@mail.mn-solutions.de>
To: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] rndis_wlan: set cipher suites for cfg80211
Date: Wed, 26 Aug 2009 15:21:29 +0200 [thread overview]
Message-ID: <200908261521.30050.hs4233@mail.mn-solutions.de> (raw)
In-Reply-To: <20090826125302.25900.98016.stgit@fate.lan>
> +static const u32 rndis_cipher_suites[] = {
> + WLAN_CIPHER_SUITE_WEP40,
> + WLAN_CIPHER_SUITE_WEP104,
> + WLAN_CIPHER_SUITE_TKIP,
> + WLAN_CIPHER_SUITE_CCMP,
> +};
> +
Okay, this is static, a.k.a. set-in-stone. Then why ...
> + memcpy(priv->cipher_suites, rndis_cipher_suites,
> + sizeof(rndis_cipher_suites));
... copy this to priv?
> + wiphy->cipher_suites = priv->cipher_suites;
> + wiphy->n_cipher_suites = ARRAY_SIZE(rndis_cipher_suites);
Wouldn't
+ wiphy->cipher_suide = rndis_cipher_suites;
+ wiphy->n_cipher_suites = ARRAY_SIZE(rndis_cipher_suites);
do the job? That way you can drop priv->cipher_suites.
--
http://www.holgerschurig.de
next prev parent reply other threads:[~2009-08-26 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-26 12:53 [PATCH] rndis_wlan: set cipher suites for cfg80211 Jussi Kivilinna
2009-08-26 13:21 ` Holger Schurig [this message]
2009-08-26 18:15 ` Jussi Kivilinna
2009-08-27 6:52 ` Holger Schurig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908261521.30050.hs4233@mail.mn-solutions.de \
--to=hs4233@mail.mn-solutions.de \
--cc=jussi.kivilinna@mbnet.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox