* [PATCH] b43: LP-PHY: Revert to the original PHY register write routine
@ 2009-08-26 21:38 Gábor Stefanik
2009-08-26 21:42 ` Gábor Stefanik
2009-08-26 21:44 ` Michael Buesch
0 siblings, 2 replies; 3+ messages in thread
From: Gábor Stefanik @ 2009-08-26 21:38 UTC (permalink / raw)
To: John Linville, Michael Buesch, Larry Finger, Mark Huijgen
Cc: Broadcom Wireless, linux-wireless
From: root <root@NR3DMain.NR3D>
After some discussion on IRC about the PHY register write change,
I am not sure anymore if this is the right thing to do.
Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
---
drivers/net/wireless/b43/phy_lp.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c
index 80f245c..a57c40d 100644
--- a/drivers/net/wireless/b43/phy_lp.c
+++ b/drivers/net/wireless/b43/phy_lp.c
@@ -1496,7 +1496,8 @@ static u16 b43_lpphy_op_read(struct b43_wldev *dev, u16 reg)
static void b43_lpphy_op_write(struct b43_wldev *dev, u16 reg, u16 value)
{
- b43_write32(dev, B43_MMIO_PHY_CONTROL, ((u32)value << 16) | reg);
+ b43_write32(dev, B43_MMIO_PHY_CONTROL, reg);
+ b43_write32(dev, B43_MMIO_PHY_DATA, value);
}
static void b43_lpphy_op_maskset(struct b43_wldev *dev, u16 reg, u16 mask,
--
1.5.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] b43: LP-PHY: Revert to the original PHY register write routine
2009-08-26 21:38 [PATCH] b43: LP-PHY: Revert to the original PHY register write routine Gábor Stefanik
@ 2009-08-26 21:42 ` Gábor Stefanik
2009-08-26 21:44 ` Michael Buesch
1 sibling, 0 replies; 3+ messages in thread
From: Gábor Stefanik @ 2009-08-26 21:42 UTC (permalink / raw)
To: John Linville, Michael Buesch, Larry Finger, Mark Huijgen
Cc: Broadcom Wireless, linux-wireless
2009/8/26 Gábor Stefanik <netrolller.3d@gmail.com>:
> From: root <root@NR3DMain.NR3D>
The joys of an accidental "sudo git format-patch"... :-)
>
> After some discussion on IRC about the PHY register write change,
> I am not sure anymore if this is the right thing to do.
>
> Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
> ---
> drivers/net/wireless/b43/phy_lp.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c
> index 80f245c..a57c40d 100644
> --- a/drivers/net/wireless/b43/phy_lp.c
> +++ b/drivers/net/wireless/b43/phy_lp.c
> @@ -1496,7 +1496,8 @@ static u16 b43_lpphy_op_read(struct b43_wldev *dev, u16 reg)
>
> static void b43_lpphy_op_write(struct b43_wldev *dev, u16 reg, u16 value)
> {
> - b43_write32(dev, B43_MMIO_PHY_CONTROL, ((u32)value << 16) | reg);
> + b43_write32(dev, B43_MMIO_PHY_CONTROL, reg);
> + b43_write32(dev, B43_MMIO_PHY_DATA, value);
> }
>
> static void b43_lpphy_op_maskset(struct b43_wldev *dev, u16 reg, u16 mask,
> --
> 1.5.6
>
>
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] b43: LP-PHY: Revert to the original PHY register write routine
2009-08-26 21:38 [PATCH] b43: LP-PHY: Revert to the original PHY register write routine Gábor Stefanik
2009-08-26 21:42 ` Gábor Stefanik
@ 2009-08-26 21:44 ` Michael Buesch
1 sibling, 0 replies; 3+ messages in thread
From: Michael Buesch @ 2009-08-26 21:44 UTC (permalink / raw)
To: Gábor Stefanik
Cc: John Linville, Larry Finger, Mark Huijgen, Broadcom Wireless,
linux-wireless
On Wednesday 26 August 2009 23:38:48 Gábor Stefanik wrote:
> From: root <root@NR3DMain.NR3D>
>
> After some discussion on IRC about the PHY register write change,
> I am not sure anymore if this is the right thing to do.
>
> Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
> ---
> drivers/net/wireless/b43/phy_lp.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c
> index 80f245c..a57c40d 100644
> --- a/drivers/net/wireless/b43/phy_lp.c
> +++ b/drivers/net/wireless/b43/phy_lp.c
> @@ -1496,7 +1496,8 @@ static u16 b43_lpphy_op_read(struct b43_wldev *dev, u16 reg)
>
> static void b43_lpphy_op_write(struct b43_wldev *dev, u16 reg, u16 value)
> {
> - b43_write32(dev, B43_MMIO_PHY_CONTROL, ((u32)value << 16) | reg);
> + b43_write32(dev, B43_MMIO_PHY_CONTROL, reg);
> + b43_write32(dev, B43_MMIO_PHY_DATA, value);
You just introduced a bug (need 16bit write).
As I said. I'm OK with it, if it works. Just submit it as separate patch in the future.
> }
>
> static void b43_lpphy_op_maskset(struct b43_wldev *dev, u16 reg, u16 mask,
--
Greetings, Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-08-26 21:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-26 21:38 [PATCH] b43: LP-PHY: Revert to the original PHY register write routine Gábor Stefanik
2009-08-26 21:42 ` Gábor Stefanik
2009-08-26 21:44 ` Michael Buesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).