From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
Catalin Marinas <catalin.marinas@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] cfg80211: clear cfg80211_inform_bss() from kmemleak reports
Date: Thu, 3 Sep 2009 13:43:19 -0700 [thread overview]
Message-ID: <20090903204319.GC3701@mosca> (raw)
In-Reply-To: <1252001837.9336.2.camel@johannes.local>
On Thu, Sep 03, 2009 at 11:17:17AM -0700, Johannes Berg wrote:
> On Thu, 2009-09-03 at 11:13 -0700, Luis R. Rodriguez wrote:
>
> > What I meant is it gobbles it up and spits another thing out. When it
> > gobbles it up the routine then uses kref_put().
> >
> > > Why can it not track this?
> >
> > It probably can, just not sure if it follows kref_put(), I was under
> > the impression here it doesn't and because of it we were getting false
> > positives. Catalin, can you confirm?
>
> Ah I'd think that if it can't track it then that's because we use a
> pointer to the middle of the struct to keep track of it much of the
> time.
So you agree with the patch but not the commit log entry?
Luis
next prev parent reply other threads:[~2009-09-03 20:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-03 6:11 [PATCH] cfg80211: clear cfg80211_inform_bss() from kmemleak reports Luis R. Rodriguez
2009-09-03 7:26 ` Johannes Berg
2009-09-03 18:13 ` Luis R. Rodriguez
2009-09-03 18:17 ` Johannes Berg
2009-09-03 20:43 ` Luis R. Rodriguez [this message]
2009-09-04 5:04 ` Johannes Berg
2009-09-04 8:25 ` Catalin Marinas
2009-09-04 21:21 ` Luis R. Rodriguez
2009-09-04 21:41 ` Luis R. Rodriguez
2009-09-04 21:58 ` Luis R. Rodriguez
2009-09-04 22:24 ` Catalin Marinas
2009-09-04 22:48 ` Luis R. Rodriguez
2009-09-05 0:03 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090903204319.GC3701@mosca \
--to=lrodriguez@atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=catalin.marinas@arm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).